Chromium Code Reviews

Unified Diff: net/http/failing_http_transaction_factory.cc

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: removed no longer needed forward declaration Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « net/cert/x509_util_unittest.cc ('k') | net/http/http_cache_transaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/failing_http_transaction_factory.cc
diff --git a/net/http/failing_http_transaction_factory.cc b/net/http/failing_http_transaction_factory.cc
index 7d49327a57a46dfec9e498da811b08310b1304b8..243416a397d6cfe6b3f213dca8f163db6f12bcc8 100644
--- a/net/http/failing_http_transaction_factory.cc
+++ b/net/http/failing_http_transaction_factory.cc
@@ -41,8 +41,8 @@ class FailingHttpTransaction : public HttpTransaction {
const CompletionCallback& callback,
const NetLogWithSource& net_log) override;
int RestartIgnoringLastError(const CompletionCallback& callback) override;
- int RestartWithCertificate(X509Certificate* client_cert,
- SSLPrivateKey* client_private_key,
+ int RestartWithCertificate(scoped_refptr<X509Certificate> client_cert,
+ scoped_refptr<SSLPrivateKey> client_private_key,
const CompletionCallback& callback) override;
int RestartWithAuth(const AuthCredentials& credentials,
const CompletionCallback& callback) override;
@@ -96,8 +96,8 @@ int FailingHttpTransaction::RestartIgnoringLastError(
}
int FailingHttpTransaction::RestartWithCertificate(
- X509Certificate* client_cert,
- SSLPrivateKey* client_private_key,
+ scoped_refptr<X509Certificate> client_cert,
+ scoped_refptr<SSLPrivateKey> client_private_key,
const CompletionCallback& callback) {
return ERR_FAILED;
}
« no previous file with comments | « net/cert/x509_util_unittest.cc ('k') | net/http/http_cache_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine