Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2683)

Unified Diff: android_webview/browser/aw_contents_client_bridge.h

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: removed no longer needed forward declaration Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_contents_client_bridge.h
diff --git a/android_webview/browser/aw_contents_client_bridge.h b/android_webview/browser/aw_contents_client_bridge.h
index a88cab0aad6ce886144f2812556ecd535c7e0665..48fde9e85dff120b407ead945e2e0b3909ea553b 100644
--- a/android_webview/browser/aw_contents_client_bridge.h
+++ b/android_webview/browser/aw_contents_client_bridge.h
@@ -122,8 +122,6 @@ class AwContentsClientBridge {
void CancelJsResult(JNIEnv*, const base::android::JavaRef<jobject>&, int id);
private:
- void HandleErrorInClientCertificateResponse(int id);
-
JavaObjectWeakGlobalRef java_ref_;
typedef const base::Callback<void(content::CertificateRequestResultType)>
@@ -131,9 +129,7 @@ class AwContentsClientBridge {
IDMap<std::unique_ptr<CertErrorCallback>> pending_cert_error_callbacks_;
IDMap<std::unique_ptr<content::JavaScriptDialogManager::DialogClosedCallback>>
pending_js_dialog_callbacks_;
- // |pending_client_cert_request_delegates_| owns its pointers, but IDMap
- // doesn't provide Release, so ownership is managed manually.
- IDMap<content::ClientCertificateDelegate*>
+ IDMap<std::unique_ptr<content::ClientCertificateDelegate>>
pending_client_cert_request_delegates_;
};
« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | android_webview/browser/aw_contents_client_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698