Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: net/url_request/url_request.cc

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: fix member order Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 148c3e805515557f4cb015d6fd880c5fdc3afe00..07550e2081511cbdcb4bbb583672c2d2a80a2e08 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -875,15 +875,17 @@ void URLRequest::CancelAuth() {
job_->CancelAuth();
}
-void URLRequest::ContinueWithCertificate(X509Certificate* client_cert,
- SSLPrivateKey* client_private_key) {
+void URLRequest::ContinueWithCertificate(
+ scoped_refptr<X509Certificate> client_cert,
+ scoped_refptr<SSLPrivateKey> client_private_key) {
DCHECK(job_.get());
// Matches the call in NotifyCertificateRequested.
OnCallToDelegateComplete();
status_ = URLRequestStatus::FromError(ERR_IO_PENDING);
- job_->ContinueWithCertificate(client_cert, client_private_key);
+ job_->ContinueWithCertificate(std::move(client_cert),
+ std::move(client_private_key));
}
void URLRequest::ContinueDespiteLastError() {

Powered by Google App Engine
This is Rietveld 408576698