Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 203a6e282086e3d0163432a31ff718c723427755..1edfb8208b961f32825ffb844e53d698b9ff46e8 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -1262,8 +1262,8 @@ void URLRequestHttpJob::CancelAuth() {
}
void URLRequestHttpJob::ContinueWithCertificate(
- X509Certificate* client_cert,
- SSLPrivateKey* client_private_key) {
+ scoped_refptr<X509Certificate> client_cert,
+ scoped_refptr<SSLPrivateKey> client_private_key) {
DCHECK(transaction_.get());
DCHECK(!response_info_) << "should not have a response yet";
@@ -1272,7 +1272,7 @@ void URLRequestHttpJob::ContinueWithCertificate(
ResetTimer();
int rv = transaction_->RestartWithCertificate(
- client_cert, client_private_key,
+ std::move(client_cert), std::move(client_private_key),
base::Bind(&URLRequestHttpJob::OnStartCompleted, base::Unretained(this)));
if (rv == ERR_IO_PENDING)
return;

Powered by Google App Engine
This is Rietveld 408576698