Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: content/public/browser/content_browser_client.h

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index a3d217fd94465febd92a71e324c331ac6150658f..72644dce5b87588f726fc52e33532b4f4ea13a8c 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -73,14 +73,14 @@ struct BindSourceInfo;
}
namespace net {
+class ClientCertIdentity;
+using ClientCertIdentityList = std::vector<std::unique_ptr<ClientCertIdentity>>;
davidben 2017/06/01 23:41:25 Do we still like to do this kind of forward decl?
mattm 2017/06/02 04:04:20 I think I did do that in most places, but since co
class CookieOptions;
class NetLog;
class SSLCertRequestInfo;
class SSLInfo;
class URLRequest;
class URLRequestContext;
-class X509Certificate;
-typedef std::vector<scoped_refptr<X509Certificate>> CertificateList;
}
namespace rappor {
@@ -482,7 +482,7 @@ class CONTENT_EXPORT ContentBrowserClient {
virtual void SelectClientCertificate(
WebContents* web_contents,
net::SSLCertRequestInfo* cert_request_info,
- net::CertificateList client_certs,
+ net::ClientCertIdentityList client_certs,
std::unique_ptr<ClientCertificateDelegate> delegate);
// Returns a class to get notifications about media event. The embedder can

Powered by Google App Engine
This is Rietveld 408576698