Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: remoting/host/token_validator_base.h

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: rebase on https://codereview.chromium.org/2899083006/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_job.cc ('k') | remoting/host/token_validator_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/token_validator_base.h
diff --git a/remoting/host/token_validator_base.h b/remoting/host/token_validator_base.h
index d6ceb9ea9be98337ac7d86adf0a98db3f17d6d75..37c385e640462f153944bb3636a441154f756468 100644
--- a/remoting/host/token_validator_base.h
+++ b/remoting/host/token_validator_base.h
@@ -18,7 +18,8 @@
namespace net {
class ClientCertStore;
-typedef std::vector<scoped_refptr<X509Certificate> > CertificateList;
+class ClientCertIdentity;
+using ClientCertIdentityList = std::vector<std::unique_ptr<ClientCertIdentity>>;
}
namespace remoting {
@@ -54,11 +55,12 @@ class TokenValidatorBase
protected:
void OnCertificatesSelected(net::ClientCertStore* unused,
- net::CertificateList selected_certs);
+ net::ClientCertIdentityList selected_certs);
virtual void StartValidateRequest(const std::string& token) = 0;
- virtual void ContinueWithCertificate(net::X509Certificate* client_cert,
- net::SSLPrivateKey* client_private_key);
+ virtual void ContinueWithCertificate(
+ scoped_refptr<net::X509Certificate> client_cert,
+ scoped_refptr<net::SSLPrivateKey> client_private_key);
virtual bool IsValidScope(const std::string& token_scope);
std::string ProcessResponse(int net_result);
« no previous file with comments | « net/url_request/url_request_job.cc ('k') | remoting/host/token_validator_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698