Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: net/url_request/url_request_job.cc

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: removed no longer needed forward declaration Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_job.h ('k') | remoting/host/token_validator_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job.h" 5 #include "net/url_request/url_request_job.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 // case the derived class should implement this! 313 // case the derived class should implement this!
314 NOTREACHED(); 314 NOTREACHED();
315 } 315 }
316 316
317 void URLRequestJob::CancelAuth() { 317 void URLRequestJob::CancelAuth() {
318 // This will only be called if NeedsAuth() returns true, in which 318 // This will only be called if NeedsAuth() returns true, in which
319 // case the derived class should implement this! 319 // case the derived class should implement this!
320 NOTREACHED(); 320 NOTREACHED();
321 } 321 }
322 322
323 void URLRequestJob::ContinueWithCertificate(X509Certificate* client_cert, 323 void URLRequestJob::ContinueWithCertificate(
324 SSLPrivateKey* client_private_key) { 324 scoped_refptr<X509Certificate> client_cert,
325 scoped_refptr<SSLPrivateKey> client_private_key) {
325 // The derived class should implement this! 326 // The derived class should implement this!
326 NOTREACHED(); 327 NOTREACHED();
327 } 328 }
328 329
329 void URLRequestJob::ContinueDespiteLastError() { 330 void URLRequestJob::ContinueDespiteLastError() {
330 // Implementations should know how to recover from errors they generate. 331 // Implementations should know how to recover from errors they generate.
331 // If this code was reached, we are trying to recover from an error that 332 // If this code was reached, we are trying to recover from an error that
332 // we don't know how to recover from. 333 // we don't know how to recover from.
333 NOTREACHED(); 334 NOTREACHED();
334 } 335 }
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 int64_t total_sent_bytes = GetTotalSentBytes(); 900 int64_t total_sent_bytes = GetTotalSentBytes();
900 DCHECK_GE(total_sent_bytes, last_notified_total_sent_bytes_); 901 DCHECK_GE(total_sent_bytes, last_notified_total_sent_bytes_);
901 if (total_sent_bytes > last_notified_total_sent_bytes_) { 902 if (total_sent_bytes > last_notified_total_sent_bytes_) {
902 network_delegate_->NotifyNetworkBytesSent( 903 network_delegate_->NotifyNetworkBytesSent(
903 request_, total_sent_bytes - last_notified_total_sent_bytes_); 904 request_, total_sent_bytes - last_notified_total_sent_bytes_);
904 } 905 }
905 last_notified_total_sent_bytes_ = total_sent_bytes; 906 last_notified_total_sent_bytes_ = total_sent_bytes;
906 } 907 }
907 908
908 } // namespace net 909 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_job.h ('k') | remoting/host/token_validator_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698