Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: net/url_request/url_request_job.cc

Issue 2898573002: Refactor client cert private key handling. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job.h" 5 #include "net/url_request/url_request_job.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 // case the derived class should implement this! 293 // case the derived class should implement this!
294 NOTREACHED(); 294 NOTREACHED();
295 } 295 }
296 296
297 void URLRequestJob::CancelAuth() { 297 void URLRequestJob::CancelAuth() {
298 // This will only be called if NeedsAuth() returns true, in which 298 // This will only be called if NeedsAuth() returns true, in which
299 // case the derived class should implement this! 299 // case the derived class should implement this!
300 NOTREACHED(); 300 NOTREACHED();
301 } 301 }
302 302
303 void URLRequestJob::ContinueWithCertificate(X509Certificate* client_cert, 303 void URLRequestJob::ContinueWithCertificate(
304 SSLPrivateKey* client_private_key) { 304 scoped_refptr<X509Certificate> client_cert,
305 scoped_refptr<SSLPrivateKey> client_private_key) {
305 // The derived class should implement this! 306 // The derived class should implement this!
306 NOTREACHED(); 307 NOTREACHED();
307 } 308 }
308 309
309 void URLRequestJob::ContinueDespiteLastError() { 310 void URLRequestJob::ContinueDespiteLastError() {
310 // Implementations should know how to recover from errors they generate. 311 // Implementations should know how to recover from errors they generate.
311 // If this code was reached, we are trying to recover from an error that 312 // If this code was reached, we are trying to recover from an error that
312 // we don't know how to recover from. 313 // we don't know how to recover from.
313 NOTREACHED(); 314 NOTREACHED();
314 } 315 }
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
852 int64_t total_sent_bytes = GetTotalSentBytes(); 853 int64_t total_sent_bytes = GetTotalSentBytes();
853 DCHECK_GE(total_sent_bytes, last_notified_total_sent_bytes_); 854 DCHECK_GE(total_sent_bytes, last_notified_total_sent_bytes_);
854 if (total_sent_bytes > last_notified_total_sent_bytes_) { 855 if (total_sent_bytes > last_notified_total_sent_bytes_) {
855 network_delegate_->NotifyNetworkBytesSent( 856 network_delegate_->NotifyNetworkBytesSent(
856 request_, total_sent_bytes - last_notified_total_sent_bytes_); 857 request_, total_sent_bytes - last_notified_total_sent_bytes_);
857 } 858 }
858 last_notified_total_sent_bytes_ = total_sent_bytes; 859 last_notified_total_sent_bytes_ = total_sent_bytes;
859 } 860 }
860 861
861 } // namespace net 862 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698