Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 2898503002: Reenable feature policy control over fullscreen (Closed)
Patch Set: Reinstate original (same-origin) wpt tests with failing expectations Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 375c004d445f9dcb1b3f735c19fced88dd62c556..cdf6804ecc77bed5c5425baec2057d503b2d93dd 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -752,6 +752,21 @@ class SitePerProcessFeaturePolicyBrowserTest
}
};
+// SitePerProcessFeaturePolicyDisabledBrowserTest
+
+class SitePerProcessFeaturePolicyDisabledBrowserTest
+ : public SitePerProcessBrowserTest {
+ public:
+ SitePerProcessFeaturePolicyDisabledBrowserTest() {}
+
+ protected:
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ SitePerProcessBrowserTest::SetUpCommandLine(command_line);
+ command_line->AppendSwitchASCII(switches::kDisableBlinkFeatures,
+ "FeaturePolicy");
+ }
+};
+
IN_PROC_BROWSER_TEST_F(SitePerProcessHighDPIBrowserTest,
SubframeLoadsWithCorrectDeviceScaleFactor) {
GURL main_url(embedded_test_server()->GetURL(
@@ -8902,10 +8917,10 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
#endif
// Check that out-of-process frames correctly calculate their ability to enter
-// fullscreen. A frame is allowed enter fullscreen if the allowFullscreen
-// attribute is present in all of its ancestor <iframe> elements. For OOPIF,
-// when a parent frame changes this attribute, the change is replicated to the
-// child frame and its proxies.
+// fullscreen when Feature Policy is disabled. A frame is allowed to enter
+// fullscreen if the allowFullscreen attribute is present in all of its ancestor
+// <iframe> elements. For OOPIF, when a parent frame changes this attribute,
+// the change is replicated to the child frame and its proxies.
//
// The test checks the following cases:
//
@@ -8913,7 +8928,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
// 2. Attribute injected dynamically via JavaScript
// 3. Multiple levels of nesting (A-embed-B-embed-C)
// 4. Cross-site subframe navigation
-IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, AllowFullscreen) {
+IN_PROC_BROWSER_TEST_F(SitePerProcessFeaturePolicyDisabledBrowserTest,
+ AllowFullscreen) {
// Load a page with a cross-site <iframe allowFullscreen>.
GURL url_1(embedded_test_server()->GetURL(
"a.com", "/page_with_allowfullscreen_frame.html"));

Powered by Google App Engine
This is Rietveld 408576698