Reenable feature policy control over fullscreen

third_party/WebKit/LayoutTests/TestExpectations

Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
index 01c8bfdd12caf85974d8806aca55001eb43d5c0c..58ab722f2584fb8b508feeebed53a95a29c88281 100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -2876,6 +2876,15 @@ crbug.com/715718 [ Win ] external/wpt/css/css-flexbox-1/flexbox_flex-natural-mix
 crbug.com/723086 virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [ Timeout ]
 crbug.com/739367 virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/fetch-event-redirect.https.html [ Timeout ]
 
+# Feature Policy changes fullscreen behaviour, tests need updating

[foolip, 2017/08/09 09:00:49]

Can you update these tests as part of this review? wpt is the main test suite
I'm using for Fullscreen development, so keeping them passing is equally
important to the others.

[iclelland, 2017/08/09 15:10:35]

Sure, I can do that. I didn't because I thought the flow was:
1. Behaviour change breaks wpt tests.
2. Spec change triggers new wpt tests.
3. Tests pass again.

This way would be
1. Behaviour change triggers new wpt tests; wpt out of sync with spec (and other
browsers).
2. Spec changes to re-align with new behaviour; back in sync with wpt tests.

As long as that's the desired flow, I can do that.

[iclelland, 2017/08/09 15:12:38]

Another way to do this would be to just update the wpt tests to avoid the
behaviour that's changing -- i.e, don't test same-origin frames -- change all of
those tests to cross-origin ones. Then when the spec changes, add explicit tests
for same-origin behaviour to wpt. WDYT?

[foolip, 2017/08/09 15:38:43]

Yes, something like that. How about:

Create a new document-fullscreen-enabled-cross-origin.html with cross-origin
documents that is per the current spec and will be passing. And allow the
current test to start failing, but by adding
document-fullscreen-enabled-expected.txt if possible.

The situation for element-ready-check-enabled-flag-not-set-manual.html will be
the same, split it into two tests where one is failing.

Then, the spec change will go together with changes to the two original tests
which will cause them to begin passing again.

(If you like, it'd be fine to add tests in the same file instead, preferable
even if it allows for any code reuse.)

+crbug.com/718155 external/wpt/fullscreen/api/document-fullscreen-enabled.html [ Failure ]
+crbug.com/718155 external/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual.html [ Failure ]
+crbug.com/718155 fullscreen/full-screen-iframe-not-allowed.html [ Failure ]
+crbug.com/718155 fullscreen/full-screen-restrictions.html [ Failure Timeout ]
+crbug.com/718155 media/video-controls-fullscreen-iframe-not-allowed.html [ Failure ]
+crbug.com/718155 virtual/android/fullscreen/full-screen-iframe-not-allowed.html [ Failure ]
+crbug.com/718155 virtual/android/fullscreen/full-screen-restrictions.html [ Failure Timeout ]
+
 # Feature Policy changes same-origin allowpaymentrequest behaviour, tests need updating
 crbug.com/718155 payments/payment-request-in-iframe.html [ Failure ]
 crbug.com/718155 payments/payment-request-in-iframe-nested-not-allowed.html [ Failure ]
@@ -2885,10 +2894,14 @@ crbug.com/737643 external/wpt/payment-request/payment-allowed-by-feature-policy.
 crbug.com/737643 external/wpt/payment-request/payment-disabled-by-feature-policy.https.sub.html [ Failure ]
 crbug.com/737643 external/wpt/webusb/usb-allowed-by-feature-policy.https.sub.html [ Failure ]
 crbug.com/737643 external/wpt/webusb/usb-disabled-by-feature-policy.https.sub.html [ Failure ]
+crbug.com/737643 http/tests/feature-policy/fullscreen-disabled.php [ Failure ]
+crbug.com/737643 http/tests/feature-policy/fullscreen-enabledforall.php [ Failure ]
 crbug.com/737643 http/tests/feature-policy/payment-disabled.php [ Failure ]
 crbug.com/737643 http/tests/feature-policy/payment-enabledforall.php [ Failure ]

[loonybear, 2017/08/08 17:55:53]

Not related to this CL, but at some point, maybe we can remove all the virtual
tests since similar stuff is being tested in wpt?

Although if we are allowing different vendors to enable different features with
FP first, we might still keep our own version of LayoutTests, WDYT?

[iclelland, 2017/08/08 20:14:26]

I sure hope so -- we could probably get rid of the feature-policy virtual test
suite now, since the basic mechanism is turned on by default now.
Probably -- with fullscreen, though, I think that we want to update the spec to
say that, even without FP, the same-origin case and the dynamic
allowfullscreen-attribute behaviour should be changed. If we can get that change
into the spec, then we can land WPT tests for it which don't require supporting
feature policy at all.

 crbug.com/737643 virtual/feature-policy/http/tests/feature-policy/payment-disabled.php [ Failure ]
 crbug.com/737643 virtual/feature-policy/http/tests/feature-policy/payment-enabledforall.php [ Failure ]
+crbug.com/737643 virtual/mojo-loading/http/tests/feature-policy/fullscreen-disabled.php [ Failure ]
+crbug.com/737643 virtual/mojo-loading/http/tests/feature-policy/fullscreen-enabledforall.php [ Failure ]
 crbug.com/737643 virtual/mojo-loading/http/tests/feature-policy/payment-disabled.php [ Failure ]
 crbug.com/737643 virtual/mojo-loading/http/tests/feature-policy/payment-enabledforall.php [ Failure ]