third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/attempt-fullscreen.html - Issue 2898503002: Reenable feature policy control over fullscreen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/attempt-fullscreen.html

Issue 2898503002: Reenable feature policy control over fullscreen (Closed)

Patch Set: Reworking tests a bit Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-not-allowed-manual.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-not-allowed-manual-expected.txt ('k') | third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/report-fullscreen-enabled.html » ('j') | third_party/WebKit/LayoutTests/http/tests/fullscreen/full-screen-iframe-legacy.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>IFrame Fullscreen API success reporter</title>

	4 <body>

	5 <script>

	6 reportFullscreenSuccessful = (success) => {

	7 return () => {

	8 parent.postMessage({"report": {

	9 "api": "fullscreen",

	10 "result": success,

	11 "frame": window.name

	12 }}, "*");

	13 };

	14 };

	15

	16 exitFullscreenAndReportSuccess = () => {

	17 document.onfullscreenchange = reportFullscreenSuccessful(true);

	18 document.exitFullscreen();
	foolip 2017/08/16 21:43:15 I suppose it was annoying to be left in fullscreen I suppose it was annoying to be left in fullscreen in manual testing. A bunch of tests do that and I haven't bothered to fix it. To make sure that exiting cannot in any way interfere with the test outcome, you can instead use t.add_cleanup(() => document.exitFullscreen()) in the test file itself. Feel free to sprinkle that one-liner in any tests you find with that problem. iclelland 2017/08/17 20:01:56 Done. Show quoted text On 2017/08/16 21:43:15, foolip wrote: > I suppose it was annoying to be left in fullscreen in manual testing. A bunch of > tests do that and I haven't bothered to fix it. To make sure that exiting cannot > in any way interfere with the test outcome, you can instead use t.add_cleanup(() > => document.exitFullscreen()) in the test file itself. Feel free to sprinkle > that one-liner in any tests you find with that problem. Done.
	19 };

	20

	21 window.addEventListener('message', e => {

	22 if (e.data.action == "report") {

	23 document.onfullscreenchange = exitFullscreenAndReportSuccess;

	24 document.onfullscreenerror = reportFullscreenSuccessful(false);

	25 document.body.requestFullscreen();

	26 }

	27 });

	28 </script>

OLD	NEW