third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/report-full-screen-enabled.html - Issue 2898503002: Reenable feature policy control over fullscreen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/report-full-screen-enabled.html

Issue 2898503002: Reenable feature policy control over fullscreen (Closed)

Patch Set: Reinstate original (same-origin) wpt tests with failing expectations Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/attempt-full-screen.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/attempt-full-screen.html ('k') | third_party/WebKit/LayoutTests/external/wpt_automation/fullscreen/auto-click.js » ('j') | third_party/WebKit/LayoutTests/http/tests/fullscreen/full-screen-enabled.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>IFrame fullscreenEnabled attribute reporter</title>

	4 <body>

	5 <script>

	6 reportFullscreenEnabled = (frame) => {
	foolip 2017/08/15 09:44:22 I think this can be simplified. Per http://softwar I think this can be simplified. Per http://software.hixie.ch/utilities/js/live-dom-viewer/saved/5303 it looks like the iframe's name correctly propagates to window.name, so you can use that. Even without it, it should be possible to use e.source, just a bit less convenient. In other words, why can't this script immediately post back, without even waiting for the page to finish loading? iclelland 2017/08/16 13:31:55 That's interesting... If the frame name is availab Show quoted text On 2017/08/15 09:44:22, foolip wrote: > I think this can be simplified. Per > http://software.hixie.ch/utilities/js/live-dom-viewer/saved/5303 it looks like > the iframe's name correctly propagates to window.name, so you can use that. Even > without it, it should be possible to use e.source, just a bit less convenient. > > In other words, why can't this script immediately post back, without even > waiting for the page to finish loading? That's interesting... If the frame name is available ambiently, then we definitely can just post back, and don't need to trigger. The trigger was just so that we could pass a token to the child frame to allow the results to be distinguished properly on the return message. In the other test, which actually enables fullscreen, I can remove the need to pass frame.name back and forth, but the trigger is still necessary in order to satisfy the gesture requirement.
	7 parent.postMessage({"report": {

	8 "api": "fullscreen",

	9 "enabled": document.webkitFullscreenEnabled,
	foolip 2017/08/15 09:44:22 Use document.fullscreenEnabled in wpt. Use document.fullscreenEnabled in wpt. iclelland 2017/08/16 13:31:55 Thanks, done. Show quoted text On 2017/08/15 09:44:22, foolip wrote: > Use document.fullscreenEnabled in wpt. Thanks, done.
	10 "frame": frame

	11 }}, "*");

	12 }

	13

	14 window.addEventListener('message', (e) => {

	15 if (e.data.action == "report") reportFullscreenEnabled(e.data.frame);

	16 });

	17 </script>

OLD	NEW