third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/attempt-full-screen.html - Issue 2898503002: Reenable feature policy control over fullscreen

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/attempt-full-screen.html

Issue 2898503002: Reenable feature policy control over fullscreen (Closed)

Patch Set: Reinstate original (same-origin) wpt tests with failing expectations Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual-expected.txt ('K') | « third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual-expected.txt ('k') | third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/report-full-screen-enabled.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/resources/report-full-screen-enabled.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>IFrame fullscreenEnabled attribute and success reporter</title>

	4 <body>

	5 <script>

	6 reportFullscreenEnabled = (frame, success) => {

	7 return () => {

	8 parent.postMessage({"report": {

	9 "api": "fullscreen",

	10 "result": [document.fullscreenEnabled, success],

	11 "frame": frame

	12 }}, "*");

	13 };

	14 };

	15

	16 window.addEventListener('message', (e) => {

	17 if (e.data.action == "report") {

	18 var frame = e.data.frame;

	19 document.onfullscreenchange = reportFullscreenEnabled(frame, true);

	20 document.onfullscreenerror = reportFullscreenEnabled(frame, false);

	21 document.body.requestFullscreen();
	foolip 2017/08/15 09:44:22 This request ought to always fail since it's not i This request ought to always fail since it's not in response to a user gesture, or possibly it depends on the timeout for user gestures? Can this be changed to click the iframe instead? I think that this file would have to include trusted-click.js, since the button has to be in this iframe. And then there's the problem that uto-click.js not working. Alternatively, if this really isn't failing due to the user gesture, that could be proven by having another test that successfully enters fullscreen in a cross-origin iframe with the same postMessage mechanism. Thoughts? iclelland 2017/08/16 13:31:55 Interesting... this is triggered by postmessage fr Show quoted text On 2017/08/15 09:44:22, foolip wrote: > This request ought to always fail since it's not in response to a user gesture, > or possibly it depends on the timeout for user gestures? Interesting... this is triggered by postmessage from the parent within a click, so it should work. (At least it appears to, and it actually goes full-screen in chrome if I add 'allowfullscreen' to the iframe tag) Show quoted text > > Can this be changed to click the iframe instead? I think that this file would > have to include trusted-click.js, since the button has to be in this iframe. And > then there's the problem that uto-click.js not working. > > Alternatively, if this really isn't failing due to the user gesture, that could > be proven by having another test that successfully enters fullscreen in a > cross-origin iframe with the same postMessage mechanism. Thoughts? I can extend it to run a second test, but I'll have to re-work the event handlers in the parent page. iclelland 2017/08/16 14:20:57 And this is done; I've split the test into two, to Show quoted text On 2017/08/16 13:31:55, iclelland wrote: > On 2017/08/15 09:44:22, foolip wrote: > > This request ought to always fail since it's not in response to a user > gesture, > > or possibly it depends on the timeout for user gestures? > > Interesting... this is triggered by postmessage from the parent within a click, > so it should work. (At least it appears to, and it actually goes full-screen in > chrome if I add 'allowfullscreen' to the iframe tag) > > > > Can this be changed to click the iframe instead? I think that this file would > > have to include trusted-click.js, since the button has to be in this iframe. > And > > then there's the problem that uto-click.js not working. > > > > Alternatively, if this really isn't failing due to the user gesture, that > could > > be proven by having another test that successfully enters fullscreen in a > > cross-origin iframe with the same postMessage mechanism. Thoughts? > > I can extend it to run a second test, but I'll have to re-work the event > handlers in the parent page. And this is done; I've split the test into two, to avoid having to do a bunch of work serializing the tests, since the test cases have to be run one after the other (unlike the fullscreenEnabled flag check). foolip 2017/08/16 21:43:14 Ah, so I guess it works because there was a user g Show quoted text On 2017/08/16 14:20:57, iclelland wrote: > On 2017/08/16 13:31:55, iclelland wrote: > > On 2017/08/15 09:44:22, foolip wrote: > > > This request ought to always fail since it's not in response to a user > > gesture, > > > or possibly it depends on the timeout for user gestures? > > > > Interesting... this is triggered by postmessage from the parent within a > click, > > so it should work. (At least it appears to, and it actually goes full-screen > in > > chrome if I add 'allowfullscreen' to the iframe tag) > > > > > > Can this be changed to click the iframe instead? I think that this file > would > > > have to include trusted-click.js, since the button has to be in this iframe. > > And > > > then there's the problem that uto-click.js not working. > > > > > > Alternatively, if this really isn't failing due to the user gesture, that > > could > > > be proven by having another test that successfully enters fullscreen in a > > > cross-origin iframe with the same postMessage mechanism. Thoughts? > > > > I can extend it to run a second test, but I'll have to re-work the event > > handlers in the parent page. > > And this is done; I've split the test into two, to avoid having to do a bunch of > work serializing the tests, since the test cases have to be run one after the > other (unlike the fullscreenEnabled flag check). Ah, so I guess it works because there was a user gesture in the last few hundred milliseconds, or whatever the rule is. I don't know how interoperable that timeout is, but we'll find out by writing tests that depend on it :)
	22 }

	23 });

	24 </script>

OLD	NEW