third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual-expected.txt - Issue 2898503002: Reenable feature policy control over fullscreen

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual-expected.txt

Issue 2898503002: Reenable feature policy control over fullscreen (Closed)

Patch Set: Reinstate original (same-origin) wpt tests with failing expectations Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 FAIL Element ready check with enabled flag not set assert_false: fullscreen enab led flag expected false got true
	foolip 2017/08/15 09:44:22 The name of this test refers to the "fullscreen en The name of this test refers to the "fullscreen enabled flag" which was removed in https://github.com/whatwg/html/pull/1492. Can you rename the result to element-ready-check-not-allowed-manual.html to match how this is currently phrased in the spec? (Elsewhere there's the question of one file vs. two files.) iclelland 2017/08/16 13:31:55 Done. This is the pre-existing test, but I've also Show quoted text On 2017/08/15 09:44:22, foolip wrote: > The name of this test refers to the "fullscreen enabled flag" which was removed > in https://github.com/whatwg/html/pull/1492. > > Can you rename the result to element-ready-check-not-allowed-manual.html to > match how this is currently phrased in the spec? (Elsewhere there's the question > of one file vs. two files.) Done. This is the pre-existing test, but I've also renamed the new one.
	3 Harness: the test ran to completion.

	4

OLD	NEW