Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/compiler/lib/src/js_backend/mirrors_data.dart

Issue 2898403002: Use failedAt in more places (Closed)
Patch Set: merge; address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/minify_namer.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/mirrors_data.dart
diff --git a/pkg/compiler/lib/src/js_backend/mirrors_data.dart b/pkg/compiler/lib/src/js_backend/mirrors_data.dart
index a3096128b408e1187399b94d1822897ed30b0e85..5432e1082601650d874662aa61de7d5d748f1d65 100644
--- a/pkg/compiler/lib/src/js_backend/mirrors_data.dart
+++ b/pkg/compiler/lib/src/js_backend/mirrors_data.dart
@@ -555,7 +555,7 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
if (isClassReferencedFromMirrorSystem(cls)) {
Set<Name> memberNames = new Set<Name>();
// 1) the class (should be resolved)
- assert(invariant(cls, cls.isResolved));
+ assert(cls.isResolved, failedAt(cls));
_classesNeededForReflection.add(cls);
// 2) its constructors (if resolved)
cls.constructors.forEach((ConstructorElement constructor) {
@@ -582,8 +582,8 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
subcls.forEachClassMember((Member member) {
if (memberNames.contains(member.name)) {
// TODO(20993): find out why this assertion fails.
- // assert(invariant(member.element,
- // worldBuilder.isMemberUsed(member.element)));
+ // assert(worldBuilder.isMemberUsed(member.element),
+ // failedAt(member.element));
if (worldBuilder.isMemberUsed(member.element)) {
_membersNeededForReflection.add(member.element);
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/minify_namer.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698