Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: pkg/compiler/lib/src/inferrer/inferrer_engine.dart

Issue 2898403002: Use failedAt in more places (Closed)
Patch Set: merge; address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/inferrer/type_system.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/inferrer_engine.dart
diff --git a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
index 4c75cce0643a6b5709952a025720427ece615d98..5672c8cd732f40bf3c3243ea76c71383209bed45 100644
--- a/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
+++ b/pkg/compiler/lib/src/inferrer/inferrer_engine.dart
@@ -397,7 +397,7 @@ class InferrerEngine {
assert(info.calledElement.isGenerativeConstructor);
ClassElement cls = info.calledElement.enclosingClass;
FunctionElement callMethod = cls.lookupMember(Identifiers.call);
- assert(invariant(cls, callMethod != null));
+ assert(callMethod != null, failedAt(cls));
Iterable<FunctionElement> elements = [callMethod];
trace(elements, new ClosureTracerVisitor(elements, info, this));
} else {
@@ -526,12 +526,13 @@ class InferrerEngine {
types.allocatedTypes.add(type);
}
} else {
- assert(invariant(
- fieldElement,
+ assert(
fieldElement.isInstanceMember ||
constant.isImplicit ||
constant.isPotential,
- message: "Constant expression without value: "
+ failedAt(
+ fieldElement,
+ "Constant expression without value: "
"${constant.toStructuredText()}."));
}
}
@@ -985,14 +986,13 @@ class InferrerEngine {
ResolvedAst resolvedAst = element.resolvedAst;
element = element.implementation;
if (element.impliesType) return;
- assert(invariant(
- element,
+ assert(
element.isField ||
element.isFunction ||
element.isConstructor ||
element.isGetter ||
element.isSetter,
- message: 'Unexpected element kind: ${element.kind}'));
+ failedAt(element, 'Unexpected element kind: ${element.kind}'));
if (element.isAbstract) return;
// Put the other operators in buckets by length, later to be added in
// length order.
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/inferrer/type_system.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698