Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2898403002: Use failedAt in more places (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge; address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -218 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 2 chunks +14 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 7 chunks +35 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +10 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 6 chunks +54 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/field_naming_mixin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer_names.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 7 chunks +33 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 3 chunks +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 4 chunks +14 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 3 chunks +12 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 2 chunks +20 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 4 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 10 chunks +17 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
3 years, 7 months ago (2017-05-24 02:32:06 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2898403002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2898403002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1459 pkg/compiler/lib/src/compiler.dart:1459: // uses. Seems like we should file a ...
3 years, 7 months ago (2017-05-24 08:24:52 UTC) #3
sra1
https://codereview.chromium.org/2898403002/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/2898403002/diff/1/pkg/compiler/lib/src/compiler.dart#newcode1459 pkg/compiler/lib/src/compiler.dart:1459: // uses. On 2017/05/24 08:24:52, Johnni Winther wrote: > ...
3 years, 6 months ago (2017-05-24 17:38:54 UTC) #4
sra1
3 years, 6 months ago (2017-05-31 10:12:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d5f213834927d2fea9afe5879989930c90346e8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698