chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc - Issue 2898393002: Split Android-specific dependency from BackgroundLoaderOffliner. Create a subfolder of c/b/offline_…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2898393002: Split Android-specific dependency from BackgroundLoaderOffliner. Create a subfolder of c/b/offline_… (Closed)

Patch Set: more build fixes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/android/offline_pages/prerendering_offliner.h » ('j') | chrome/browser/android/offline_pages/prerendering_offliner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

index 3d0b37ce1982156f8e7791d9b7fb3614e41a7cbb..4a68c9c5cb7367db434d91fbe02a07758521ff00 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

@@ -174,7 +174,8 @@ std::unique_ptr<KeyedService> GetTestBackgroundLoaderRequestCoordinator(

std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());

std::unique_ptr<Offliner> offliner(new BackgroundLoaderOffliner(

context, policy.get(),

- OfflinePageModelFactory::GetForBrowserContext(context)));

+ OfflinePageModelFactory::GetForBrowserContext(context),

+ nullptr)); // no need to connect LoadTerminatorListener for harness.

dewittj 2017/05/24 23:24:39 nit: LoadTerminationListener

Dmitry Titov 2017/05/25 23:24:12 Done in followup CL

return GetTestingRequestCoordinator(context, std::move(policy),

std::move(offliner));

}