Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const. (Closed)
Patch Set: sync @tott Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index fee129eafcbea0ad3584bfb24e758ef04ed1412c..4d12677ecdd90dc1ee6a9baa666884869f21a514 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -714,25 +714,23 @@ void MenuManager::ExecuteCommand(content::BrowserContext* context,
{
// Dispatch to menu item's .onclick handler (this is the legacy API, from
// before chrome.contextMenus.onClicked existed).
- std::unique_ptr<Event> event(
- new Event(webview_guest ? events::WEB_VIEW_INTERNAL_CONTEXT_MENUS
- : events::CONTEXT_MENUS,
- webview_guest ? kOnWebviewContextMenus : kOnContextMenus,
- std::unique_ptr<base::ListValue>(args->DeepCopy())));
- event->restrict_to_browser_context = context;
+ auto event = base::MakeUnique<Event>(
+ webview_guest ? events::WEB_VIEW_INTERNAL_CONTEXT_MENUS
+ : events::CONTEXT_MENUS,
+ webview_guest ? kOnWebviewContextMenus : kOnContextMenus,
+ std::unique_ptr<base::ListValue>(args->DeepCopy()), context);
event->user_gesture = EventRouter::USER_GESTURE_ENABLED;
event_router->DispatchEventToExtension(item->extension_id(),
std::move(event));
}
{
// Dispatch to .contextMenus.onClicked handler.
- std::unique_ptr<Event> event(new Event(
+ auto event = base::MakeUnique<Event>(
webview_guest ? events::CHROME_WEB_VIEW_INTERNAL_ON_CLICKED
: events::CONTEXT_MENUS_ON_CLICKED,
webview_guest ? api::chrome_web_view_internal::OnClicked::kEventName
: api::context_menus::OnClicked::kEventName,
- std::move(args)));
- event->restrict_to_browser_context = context;
+ std::move(args), context);
event->user_gesture = EventRouter::USER_GESTURE_ENABLED;
if (webview_guest)
event->filter_info.SetInstanceID(webview_guest->view_instance_id());
« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698