Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2443)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.cc

Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const. (Closed)
Patch Set: sync @tott Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
index b9968c7e56edcc57932c268b9f446f2008cd8af6..53fa5a613b4fe54ce0754d73222fedf46b7c3fae 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
@@ -204,9 +204,9 @@ void TabsEventRouter::TabCreatedAt(WebContents* contents,
bool active) {
Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
std::unique_ptr<base::ListValue> args(new base::ListValue);
- std::unique_ptr<Event> event(new Event(
- events::TABS_ON_CREATED, tabs::OnCreated::kEventName, std::move(args)));
- event->restrict_to_browser_context = profile;
+ auto event = base::MakeUnique<Event>(events::TABS_ON_CREATED,
+ tabs::OnCreated::kEventName,
+ std::move(args), profile);
event->user_gesture = EventRouter::USER_GESTURE_NOT_ENABLED;
event->will_dispatch_callback =
base::Bind(&WillDispatchTabCreatedEvent, contents, active);
@@ -427,9 +427,8 @@ void TabsEventRouter::DispatchEvent(
if (!profile_->IsSameProfile(profile) || !event_router)
return;
- std::unique_ptr<Event> event(
- new Event(histogram_value, event_name, std::move(args)));
- event->restrict_to_browser_context = profile;
+ auto event = base::MakeUnique<Event>(histogram_value, event_name,
+ std::move(args), profile);
event->user_gesture = user_gesture;
event_router->BroadcastEvent(std::move(event));
}
@@ -455,10 +454,9 @@ void TabsEventRouter::DispatchTabUpdatedEvent(
// WillDispatchTabUpdatedEvent.
Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
- std::unique_ptr<Event> event(new Event(events::TABS_ON_UPDATED,
- tabs::OnUpdated::kEventName,
- std::move(args_base)));
- event->restrict_to_browser_context = profile;
+ auto event = base::MakeUnique<Event>(events::TABS_ON_UPDATED,
+ tabs::OnUpdated::kEventName,
+ std::move(args_base), profile);
event->user_gesture = EventRouter::USER_GESTURE_NOT_ENABLED;
event->will_dispatch_callback =
base::Bind(&WillDispatchTabUpdatedEvent, contents,

Powered by Google App Engine
This is Rietveld 408576698