chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc - Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const. (Closed)

Patch Set: sync @tott Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc ('k') | chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

diff --git a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

index eb46006f4f0367ad27321fd6cf700a2902638f50..09f07b94b4d2b1943b54a639d5d1d34f10f4da20 100644

--- a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

+++ b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

@@ -7,6 +7,7 @@

#include <utility>

#include "base/lazy_instance.h"

+#include "base/memory/ptr_util.h"

#include "chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h"

#include "chrome/browser/sync_file_system/sync_event_observer.h"

#include "chrome/browser/sync_file_system/sync_file_system_service.h"

@@ -128,9 +129,8 @@ void ExtensionSyncEventObserver::BroadcastOrDispatchEvent(

EventRouter* event_router = EventRouter::Get(browser_context_);

DCHECK(event_router);

- std::unique_ptr<Event> event(

- new Event(histogram_value, event_name, std::move(values)));

- event->restrict_to_browser_context = browser_context_;

+ auto event = base::MakeUnique<Event>(histogram_value, event_name,

+ std::move(values), browser_context_);

// No app_origin, broadcast to all listening extensions for this event name.

if (broadcast_mode) {