Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: chrome/browser/chromeos/extensions/ime_menu_event_router.cc

Issue 2898383002: [Extensions] Make Event::restrict_to_browser_context const. (Closed)
Patch Set: sync @tott Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/ime_menu_event_router.cc
diff --git a/chrome/browser/chromeos/extensions/ime_menu_event_router.cc b/chrome/browser/chromeos/extensions/ime_menu_event_router.cc
index 8e5e9924e77e591f00e630cfde99416eb2819bee..19ba2a26e0653e728e080023b7fdb730bce95c5a 100644
--- a/chrome/browser/chromeos/extensions/ime_menu_event_router.cc
+++ b/chrome/browser/chromeos/extensions/ime_menu_event_router.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/chromeos/extensions/ime_menu_event_router.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/chromeos/extensions/input_method_api.h"
#include "chrome/common/extensions/api/input_method_private.h"
@@ -40,10 +41,9 @@ void ExtensionImeMenuEventRouter::ImeMenuActivationChanged(bool activation) {
args->AppendBoolean(activation);
// The router will only send the event to extensions that are listening.
- std::unique_ptr<extensions::Event> event(new extensions::Event(
+ auto event = base::MakeUnique<extensions::Event>(
extensions::events::INPUT_METHOD_PRIVATE_ON_IME_MENU_ACTIVATION_CHANGED,
- OnImeMenuActivationChanged::kEventName, std::move(args)));
- event->restrict_to_browser_context = context_;
+ OnImeMenuActivationChanged::kEventName, std::move(args), context_);
router->BroadcastEvent(std::move(event));
}
@@ -56,10 +56,9 @@ void ExtensionImeMenuEventRouter::ImeMenuListChanged() {
std::unique_ptr<base::ListValue> args(new base::ListValue());
// The router will only send the event to extensions that are listening.
- std::unique_ptr<extensions::Event> event(new extensions::Event(
+ auto event = base::MakeUnique<extensions::Event>(
extensions::events::INPUT_METHOD_PRIVATE_ON_IME_MENU_LIST_CHANGED,
- OnImeMenuListChanged::kEventName, std::move(args)));
- event->restrict_to_browser_context = context_;
+ OnImeMenuListChanged::kEventName, std::move(args), context_);
router->BroadcastEvent(std::move(event));
}
@@ -99,10 +98,9 @@ void ExtensionImeMenuEventRouter::ImeMenuItemsChanged(
OnImeMenuItemsChanged::Create(engine_id, menu_items);
// The router will only send the event to extensions that are listening.
- std::unique_ptr<extensions::Event> event(new extensions::Event(
+ auto event = base::MakeUnique<extensions::Event>(
extensions::events::INPUT_METHOD_PRIVATE_ON_IME_MENU_ITEMS_CHANGED,
- OnImeMenuItemsChanged::kEventName, std::move(args)));
- event->restrict_to_browser_context = context_;
+ OnImeMenuItemsChanged::kEventName, std::move(args), context_);
router->BroadcastEvent(std::move(event));
}

Powered by Google App Engine
This is Rietveld 408576698