Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Issue 2898303004: [MD Bookmarks] Add toasts. (Closed)
Patch Set: fix nits Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/webui/plural_string_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h" 5 #include "chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.h" 12 #include "chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.h"
13 #include "chrome/browser/ui/webui/plural_string_handler.h"
13 #include "chrome/common/chrome_features.h" 14 #include "chrome/common/chrome_features.h"
14 #include "chrome/common/url_constants.h" 15 #include "chrome/common/url_constants.h"
15 #include "chrome/grit/browser_resources.h" 16 #include "chrome/grit/browser_resources.h"
16 #include "chrome/grit/generated_resources.h" 17 #include "chrome/grit/generated_resources.h"
17 #include "components/strings/grit/components_strings.h" 18 #include "components/strings/grit/components_strings.h"
18 #include "content/public/browser/web_ui.h" 19 #include "content/public/browser/web_ui.h"
19 #include "content/public/browser/web_ui_data_source.h" 20 #include "content/public/browser/web_ui_data_source.h"
20 #include "ui/base/l10n/l10n_util.h" 21 #include "ui/base/l10n/l10n_util.h"
21 22
22 namespace { 23 namespace {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 AddLocalizedString(source, "menuRename", IDS_MD_BOOKMARK_MANAGER_MENU_RENAME); 80 AddLocalizedString(source, "menuRename", IDS_MD_BOOKMARK_MANAGER_MENU_RENAME);
80 AddLocalizedString(source, "menuSort", IDS_MD_BOOKMARK_MANAGER_MENU_SORT); 81 AddLocalizedString(source, "menuSort", IDS_MD_BOOKMARK_MANAGER_MENU_SORT);
81 AddLocalizedString(source, "noSearchResults", 82 AddLocalizedString(source, "noSearchResults",
82 IDS_MD_BOOKMARK_MANAGER_NO_SEARCH_RESULTS); 83 IDS_MD_BOOKMARK_MANAGER_NO_SEARCH_RESULTS);
83 AddLocalizedString(source, "renameFolderTitle", 84 AddLocalizedString(source, "renameFolderTitle",
84 IDS_MD_BOOKMARK_MANAGER_FOLDER_RENAME_TITLE); 85 IDS_MD_BOOKMARK_MANAGER_FOLDER_RENAME_TITLE);
85 AddLocalizedString(source, "searchPrompt", 86 AddLocalizedString(source, "searchPrompt",
86 IDS_BOOKMARK_MANAGER_SEARCH_BUTTON); 87 IDS_BOOKMARK_MANAGER_SEARCH_BUTTON);
87 AddLocalizedString(source, "saveEdit", IDS_SAVE); 88 AddLocalizedString(source, "saveEdit", IDS_SAVE);
88 AddLocalizedString(source, "title", IDS_MD_BOOKMARK_MANAGER_TITLE); 89 AddLocalizedString(source, "title", IDS_MD_BOOKMARK_MANAGER_TITLE);
90 AddLocalizedString(source, "toastFolderSorted",
91 IDS_MD_BOOKMARK_MANAGER_TOAST_FOLDER_SORTED);
92 AddLocalizedString(source, "toastItemDeleted",
93 IDS_MD_BOOKMARK_MANAGER_TOAST_ITEM_DELETED);
94 AddLocalizedString(source, "toastUrlCopied",
95 IDS_MD_BOOKMARK_MANAGER_TOAST_URL_COPIED);
96 AddLocalizedString(source, "undo", IDS_BOOKMARK_BAR_UNDO);
89 97
90 // Resources. 98 // Resources.
91 #if BUILDFLAG(USE_VULCANIZE) 99 #if BUILDFLAG(USE_VULCANIZE)
92 source->AddResourcePath("crisper.js", IDR_MD_BOOKMARKS_CRISPER_JS); 100 source->AddResourcePath("crisper.js", IDR_MD_BOOKMARKS_CRISPER_JS);
93 source->SetDefaultResource(IDR_MD_BOOKMARKS_VULCANIZED_HTML); 101 source->SetDefaultResource(IDR_MD_BOOKMARKS_VULCANIZED_HTML);
94 source->UseGzip(std::unordered_set<std::string>()); 102 source->UseGzip(std::unordered_set<std::string>());
95 #else 103 #else
96 source->AddResourcePath("actions.html", IDR_MD_BOOKMARKS_ACTIONS_HTML); 104 source->AddResourcePath("actions.html", IDR_MD_BOOKMARKS_ACTIONS_HTML);
97 source->AddResourcePath("actions.js", IDR_MD_BOOKMARKS_ACTIONS_JS); 105 source->AddResourcePath("actions.js", IDR_MD_BOOKMARKS_ACTIONS_JS);
98 source->AddResourcePath("api_listener.html", 106 source->AddResourcePath("api_listener.html",
(...skipping 28 matching lines...) Expand all
127 source->AddResourcePath("router.js", IDR_MD_BOOKMARKS_ROUTER_JS); 135 source->AddResourcePath("router.js", IDR_MD_BOOKMARKS_ROUTER_JS);
128 source->AddResourcePath("shared_style.html", 136 source->AddResourcePath("shared_style.html",
129 IDR_MD_BOOKMARKS_SHARED_STYLE_HTML); 137 IDR_MD_BOOKMARKS_SHARED_STYLE_HTML);
130 source->AddResourcePath("shared_vars.html", 138 source->AddResourcePath("shared_vars.html",
131 IDR_MD_BOOKMARKS_SHARED_VARS_HTML); 139 IDR_MD_BOOKMARKS_SHARED_VARS_HTML);
132 source->AddResourcePath("store.html", IDR_MD_BOOKMARKS_STORE_HTML); 140 source->AddResourcePath("store.html", IDR_MD_BOOKMARKS_STORE_HTML);
133 source->AddResourcePath("store.js", IDR_MD_BOOKMARKS_STORE_JS); 141 source->AddResourcePath("store.js", IDR_MD_BOOKMARKS_STORE_JS);
134 source->AddResourcePath("store_client.html", 142 source->AddResourcePath("store_client.html",
135 IDR_MD_BOOKMARKS_STORE_CLIENT_HTML); 143 IDR_MD_BOOKMARKS_STORE_CLIENT_HTML);
136 source->AddResourcePath("store_client.js", IDR_MD_BOOKMARKS_STORE_CLIENT_JS); 144 source->AddResourcePath("store_client.js", IDR_MD_BOOKMARKS_STORE_CLIENT_JS);
145 source->AddResourcePath("toast_manager.html",
146 IDR_MD_BOOKMARKS_TOAST_MANAGER_HTML);
147 source->AddResourcePath("toast_manager.js",
148 IDR_MD_BOOKMARKS_TOAST_MANAGER_JS);
137 source->AddResourcePath("toolbar.html", IDR_MD_BOOKMARKS_TOOLBAR_HTML); 149 source->AddResourcePath("toolbar.html", IDR_MD_BOOKMARKS_TOOLBAR_HTML);
138 source->AddResourcePath("toolbar.js", IDR_MD_BOOKMARKS_TOOLBAR_JS); 150 source->AddResourcePath("toolbar.js", IDR_MD_BOOKMARKS_TOOLBAR_JS);
139 source->AddResourcePath("util.html", IDR_MD_BOOKMARKS_UTIL_HTML); 151 source->AddResourcePath("util.html", IDR_MD_BOOKMARKS_UTIL_HTML);
140 source->AddResourcePath("util.js", IDR_MD_BOOKMARKS_UTIL_JS); 152 source->AddResourcePath("util.js", IDR_MD_BOOKMARKS_UTIL_JS);
141 153
142 source->SetDefaultResource(IDR_MD_BOOKMARKS_BOOKMARKS_HTML); 154 source->SetDefaultResource(IDR_MD_BOOKMARKS_BOOKMARKS_HTML);
143 #endif 155 #endif
144 156
145 source->SetJsonPath("strings.js"); 157 source->SetJsonPath("strings.js");
146 158
147 return source; 159 return source;
148 } 160 }
149 161
150 } // namespace 162 } // namespace
151 163
152 MdBookmarksUI::MdBookmarksUI(content::WebUI* web_ui) : WebUIController(web_ui) { 164 MdBookmarksUI::MdBookmarksUI(content::WebUI* web_ui) : WebUIController(web_ui) {
153 // Set up the chrome://bookmarks/ source. 165 // Set up the chrome://bookmarks/ source.
154 Profile* profile = Profile::FromWebUI(web_ui); 166 Profile* profile = Profile::FromWebUI(web_ui);
155 content::WebUIDataSource::Add(profile, 167 content::WebUIDataSource::Add(profile,
156 CreateMdBookmarksUIHTMLSource(profile)); 168 CreateMdBookmarksUIHTMLSource(profile));
157 169
170 auto plural_string_handler = base::MakeUnique<PluralStringHandler>();
171 plural_string_handler->AddLocalizedString(
172 "toastItemsDeleted", IDS_MD_BOOKMARK_MANAGER_TOAST_ITEMS_DELETED);
173 web_ui->AddMessageHandler(std::move(plural_string_handler));
174
158 web_ui->AddMessageHandler(base::MakeUnique<BookmarksMessageHandler>()); 175 web_ui->AddMessageHandler(base::MakeUnique<BookmarksMessageHandler>());
159 } 176 }
160 177
161 // static 178 // static
162 bool MdBookmarksUI::IsEnabled() { 179 bool MdBookmarksUI::IsEnabled() {
163 return base::FeatureList::IsEnabled(features::kMaterialDesignBookmarks); 180 return base::FeatureList::IsEnabled(features::kMaterialDesignBookmarks);
164 } 181 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/webui/plural_string_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698