chrome/browser/resources/md_bookmarks/toast.html - Issue 2898303004: [MD Bookmarks] Add toasts.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_bookmarks/toast.html

Issue 2898303004: [MD Bookmarks] Add toasts. (Closed)

Patch Set: address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/app/bookmarks_strings.grdp ('K') | « chrome/browser/resources/md_bookmarks/compiled_resources2.gyp ('k') | chrome/browser/resources/md_bookmarks/toast.js » ('j') | chrome/browser/resources/md_bookmarks/toast.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2

	3 <dom-module id="bookmarks-toast">
	tsergeant 2017/06/01 08:25:00 To be honest, I don't really see the need to make To be honest, I don't really see the need to make a distinction between bookmarks-toast and bookmarks-toast-manager anymore, except for the fact that maybe one day we will want to share one but not the other. <bookmarks-toast> is simple enough that I think we should just implement it in <bookmarks-toast-manager> directly. Sorry for causing even more churn on this CL. calamity 2017/06/02 05:34:22 Done. Show quoted text On 2017/06/01 08:25:00, tsergeant wrote: > To be honest, I don't really see the need to make a distinction between > bookmarks-toast and bookmarks-toast-manager anymore, except for the fact that > maybe one day we will want to share one but not the other. > > <bookmarks-toast> is simple enough that I think we should just implement it in > <bookmarks-toast-manager> directly. > > Sorry for causing even more churn on this CL. Done.
	4 <template>

	5 <style>

	6 :host {

	7 align-items: center;

	8 background-color: var(--bookmarks-toast-background-color, #323232);
	tsergeant 2017/06/01 08:25:00 Relatedly, I don't think we need to have these unu Relatedly, I don't think we need to have these unused CSS vars lying around calamity 2017/06/02 05:34:22 Done. Show quoted text On 2017/06/01 08:25:00, tsergeant wrote: > Relatedly, I don't think we need to have these unused CSS vars lying around Done.
	9 border-radius: 4px;

	10 bottom: 0;

	11 box-shadow: 0 2px 4px 0 rgba(0, 0, 0, 0.28);

	12 box-sizing: border-box;

	13 color: var(--bookmarks-toast-color, #fff);

	14 display: flex;

	15 margin: 24px;

	16 max-width: 568px;

	17 min-height: 52px;

	18 min-width: 288px;

	19 opacity: 0;

	20 padding: 0 24px;

	21 position: fixed;

	22 transform: translateY(100px);

	23 transition: transform 300ms, opacity 300ms;

	24 white-space: nowrap;

	25 }

	26

	27 :host([open]) {

	28 opacity: 1;

	29 transform: translateY(0);

	30 }

	31 </style>

	32 <slot></slot>

	33 </template>

	34 <script src="chrome://bookmarks/toast.js"></script>

	35 </dom-module>

OLD	NEW