Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: Source/core/page/Page.cpp

Issue 28983004: Split the frame tree logic out of HistoryItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index 052fb819415c90f52ae781ba686983b0623ebe27..7411d3f4430862bec1f20a20c0ac47d5b2cb949c 100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -103,6 +103,7 @@ Page::Page(PageClients& pageClients)
, m_contextMenuController(ContextMenuController::create(this, pageClients.contextMenuClient))
, m_inspectorController(InspectorController::create(this, pageClients.inspectorClient))
, m_pointerLockController(PointerLockController::create(this))
+ , m_history(adoptPtr(new HistoryController(this)))
, m_settings(Settings::create(this))
, m_progress(ProgressTracker::create())
, m_backForwardClient(pageClients.backForwardClient)
@@ -280,13 +281,6 @@ void Page::setOpenedByDOM()
void Page::goToItem(HistoryItem* item)
{
- // stopAllLoaders may end up running onload handlers, which could cause further history traversals that may lead to the passed in HistoryItem
- // being deref()-ed. Make sure we can still use it with HistoryController::goToItem later.
- RefPtr<HistoryItem> protector(item);
-
- if (m_mainFrame->loader().history()->shouldStopLoadingForHistoryItem(item))
- m_mainFrame->loader().stopAllLoaders();
-
m_mainFrame->loader().history()->goToItem(item);
}

Powered by Google App Engine
This is Rietveld 408576698