Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: Source/core/history/HistoryItem.h

Issue 28983004: Split the frame tree logic out of HistoryItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/history/HistoryItem.h
diff --git a/Source/core/history/HistoryItem.h b/Source/core/history/HistoryItem.h
index 15793db5257715c5c1aefb330499eba38d72e469..4fc9326dd416210113fe5ced925a48cccf828296 100644
--- a/Source/core/history/HistoryItem.h
+++ b/Source/core/history/HistoryItem.h
@@ -91,33 +91,23 @@ public:
void setDocumentSequenceNumber(long long number) { m_documentSequenceNumber = number; }
long long documentSequenceNumber() const { return m_documentSequenceNumber; }
+ void setTargetFrameID(int64_t number) { m_targetFrameID = number; }
abarth-chromium 2013/10/29 20:36:58 s/number/id/ ?
+ int64_t targetFrameID() const { return m_targetFrameID; }
+
void setFormInfoFromRequest(const ResourceRequest&);
void setFormData(PassRefPtr<FormData>);
void setFormContentType(const String&);
void addChildItem(PassRefPtr<HistoryItem>);
- void setChildItem(PassRefPtr<HistoryItem>);
- HistoryItem* childItemWithTarget(const String&) const;
- HistoryItem* childItemWithDocumentSequenceNumber(long long number) const;
const HistoryItemVector& children() const;
void clearChildren();
- bool shouldDoSameDocumentNavigationTo(HistoryItem* otherItem) const;
- bool hasSameFrames(HistoryItem* otherItem) const;
-
bool isCurrentDocument(Document*) const;
-#ifndef NDEBUG
- int showTree() const;
- int showTreeWithIndent(unsigned indentLevel) const;
-#endif
-
private:
HistoryItem();
explicit HistoryItem(const HistoryItem&);
- bool hasSameDocumentTree(HistoryItem* otherItem) const;
-
String m_urlString;
String m_originalURLString;
String m_referrer;
@@ -140,6 +130,8 @@ private:
// such HistoryItem to another preserves the document.
int64_t m_documentSequenceNumber;
+ int64_t m_targetFrameID;
+
// Support for HTML5 History
RefPtr<SerializedScriptValue> m_stateObject;
@@ -151,9 +143,4 @@ private:
} //namespace WebCore
-#ifndef NDEBUG
-// Outside the WebCore namespace for ease of invocation from gdb.
-extern "C" int showTree(const WebCore::HistoryItem*);
-#endif
-
#endif // HISTORYITEM_H

Powered by Google App Engine
This is Rietveld 408576698