Source/web/tests/WebFrameTest.cpp - Issue 28983004: Split the frame tree logic out of HistoryItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 28983004: Split the frame tree logic out of HistoryItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 93b7ceb6b03faf8c753103139523fc77a0b7c03b..041445a1b38d95258a92f38b74811049993e19d3 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -1609,9 +1609,9 @@ TEST_F(WebFrameTest, pageScaleFactorWrittenToHistoryItem)

webViewHelper.webView()->layout();

webViewHelper.webView()->setPageScaleFactor(3, WebPoint());

- webViewHelper.webViewImpl()->page()->mainFrame()->loader().history()->saveDocumentAndScrollState();

+ webViewHelper.webViewImpl()->page()->history()->saveDocumentAndScrollState(webViewHelper.webViewImpl()->page()->mainFrame());

webViewHelper.webView()->setPageScaleFactor(1, WebPoint());

- webViewHelper.webViewImpl()->page()->mainFrame()->loader().history()->restoreScrollPositionAndViewState();

+ webViewHelper.webViewImpl()->page()->history()->restoreScrollPositionAndViewState(webViewHelper.webViewImpl()->page()->mainFrame());

EXPECT_EQ(3, webViewHelper.webView()->pageScaleFactor());

}