Source/web/ContextMenuClientImpl.cpp - Issue 28983004: Split the frame tree logic out of HistoryItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 28983004: Split the frame tree logic out of HistoryItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index c2bac497afd9904525288e442b85c8a0cd06a706..840b34d83949587df045d0fb5ccb4f46612ebf57 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -290,7 +290,7 @@ void ContextMenuClientImpl::showContextMenu(const WebCore::ContextMenu* defaultM

data.pageURL = urlFromFrame(m_webView->mainFrameImpl()->frame());

if (selectedFrame != m_webView->mainFrameImpl()->frame()) {

data.frameURL = urlFromFrame(selectedFrame);

- RefPtr<HistoryItem> historyItem = selectedFrame->loader().history()->currentItem();

+ RefPtr<HistoryItem> historyItem = selectedFrame->page()->history()->currentItem(selectedFrame);

if (historyItem)

data.frameHistoryItem = WebHistoryItem(historyItem);

}