Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: Source/core/loader/FrameLoader.h

Issue 28983004: Split the frame tree logic out of HistoryItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoader.h
diff --git a/Source/core/loader/FrameLoader.h b/Source/core/loader/FrameLoader.h
index 3b4b62a6aa0302e3ad63fdbca6d9abd062f5e58e..d928b5b2f62fb61750725d013b08254325bb5d6d 100644
--- a/Source/core/loader/FrameLoader.h
+++ b/Source/core/loader/FrameLoader.h
@@ -82,17 +82,13 @@ public:
Frame* frame() const { return m_frame; }
- HistoryController* history() const { return &m_history; }
-
IconController* icon() const { return m_icon.get(); }
MixedContentChecker* mixedContentChecker() const { return &m_mixedContentChecker; }
- void prepareForHistoryNavigation();
-
// These functions start a load. All eventually call into loadWithNavigationAction() or loadInSameDocument().
void load(const FrameLoadRequest&); // The entry point for non-reload, non-history loads.
void reload(ReloadPolicy = NormalReload, const KURL& overrideURL = KURL(), const String& overrideEncoding = String());
- void loadHistoryItem(HistoryItem*); // The entry point for all back/forward loads
+ void loadHistoryItem(HistoryItem*, HistoryLoadType = HistoryDifferentDocumentLoad); // The entry point for all back/forward loads
static void reportLocalLoadFailed(Frame*, const String& url);
@@ -135,6 +131,7 @@ public:
bool subframeIsLoading() const;
+ bool shouldTreatURLAsSameAsCurrent(const KURL&) const;
bool shouldTreatURLAsSrcdocDocument(const KURL&) const;
FrameLoadType loadType() const;
@@ -212,6 +209,8 @@ public:
void updateForSameDocumentNavigation(const KURL&, SameDocumentNavigationSource, PassRefPtr<SerializedScriptValue>, UpdateBackForwardListPolicy);
private:
+ HistoryController* history() const;
+
bool allChildrenAreComplete() const; // immediate children, not all descendants
void completed();
@@ -219,8 +218,6 @@ private:
void checkTimerFired(Timer<FrameLoader>*);
void didAccessInitialDocumentTimerFired(Timer<FrameLoader>*);
- void insertDummyHistoryItem();
-
bool prepareRequestForThisFrame(FrameLoadRequest&);
void setReferrerForFrameRequest(ResourceRequest&, ShouldSendReferrer);
FrameLoadType determineFrameLoadType(const FrameLoadRequest&);
@@ -250,15 +247,12 @@ private:
void scheduleCheckCompleted();
void startCheckCompleteTimer();
- bool shouldTreatURLAsSameAsCurrent(const KURL&) const;
-
Frame* m_frame;
FrameLoaderClient* m_client;
// FIXME: These should be OwnPtr<T> to reduce build times and simplify
// header dependencies unless performance testing proves otherwise.
// Some of these could be lazily created for memory savings on devices.
- mutable HistoryController m_history;
mutable FrameLoaderStateMachine m_stateMachine;
OwnPtr<IconController> m_icon;
mutable MixedContentChecker m_mixedContentChecker;

Powered by Google App Engine
This is Rietveld 408576698