Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/core/frame/History.cpp

Issue 28983004: Split the frame tree logic out of HistoryItem (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/history/HistoryItem.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 { 63 {
64 m_lastStateObjectRequested = stateInternal(); 64 m_lastStateObjectRequested = stateInternal();
65 return m_lastStateObjectRequested.get(); 65 return m_lastStateObjectRequested.get();
66 } 66 }
67 67
68 SerializedScriptValue* History::stateInternal() const 68 SerializedScriptValue* History::stateInternal() const
69 { 69 {
70 if (!m_frame) 70 if (!m_frame)
71 return 0; 71 return 0;
72 72
73 if (HistoryItem* historyItem = m_frame->loader().history()->currentItem()) 73 if (HistoryItem* historyItem = m_frame->page()->history()->currentItem(m_fra me))
74 return historyItem->stateObject(); 74 return historyItem->stateObject();
75 75
76 return 0; 76 return 0;
77 } 77 }
78 78
79 bool History::stateChanged() const 79 bool History::stateChanged() const
80 { 80 {
81 return m_lastStateObjectRequested != stateInternal(); 81 return m_lastStateObjectRequested != stateInternal();
82 } 82 }
83 83
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 KURL fullURL = urlForState(urlString); 150 KURL fullURL = urlForState(urlString);
151 if (!fullURL.isValid() || !m_frame->document()->securityOrigin()->canRequest (fullURL)) { 151 if (!fullURL.isValid() || !m_frame->document()->securityOrigin()->canRequest (fullURL)) {
152 // We can safely expose the URL to JavaScript, as a) no redirection take s place: JavaScript already had this URL, b) JavaScript can only access a same-o rigin History object. 152 // We can safely expose the URL to JavaScript, as a) no redirection take s place: JavaScript already had this URL, b) JavaScript can only access a same-o rigin History object.
153 es.throwSecurityError("A history state object with URL '" + fullURL.elid edString() + "' cannot be created in a document with origin '" + m_frame->docume nt()->securityOrigin()->toString() + "'."); 153 es.throwSecurityError("A history state object with URL '" + fullURL.elid edString() + "' cannot be created in a document with origin '" + m_frame->docume nt()->securityOrigin()->toString() + "'.");
154 return; 154 return;
155 } 155 }
156 m_frame->loader().updateForSameDocumentNavigation(fullURL, sameDocumentNavig ationSource, data, FrameLoader::DoNotUpdateBackForwardList); 156 m_frame->loader().updateForSameDocumentNavigation(fullURL, sameDocumentNavig ationSource, data, FrameLoader::DoNotUpdateBackForwardList);
157 } 157 }
158 158
159 } // namespace WebCore 159 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/history/HistoryItem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698