Issue 2898183004: fix: build on sierra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2898183004: fix: build on sierra

Created:
3 years, 7 months ago by omerjerk

Modified:
3 years, 7 months ago

Reviewers:
caitp

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fix: build on sierra This is not the intended final commit. BUG=build fails on MacOS Sierra

Patch Set 1 #

Patch Set 2 : fix: build on sierra #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mac/find_sdk.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dan Ehrenberg

I've had this problem too, where it seemed like I needed to make a change ...

3 years, 7 months ago (2017-05-24 18:51:53 UTC) #2

caitp

3 years, 7 months ago (2017-05-24 18:52:19 UTC) #4

To add reviewers, click on "edit issue" in the top left corner (just above
"Publish+Mail Comments", and type in names of reviewers. A good way to find
reviewers is to check the various OWNERS files in the repro, but another option
is to just check the history/blame of the files you're editing.

Hope that helps a bit, good luck with contributing to v8. Don't hesitate to send
more email or ask for help in the #v8 IRC channel on freenode
(http://webchat.freenode.net?randomnick=1&channels=%23v8&uio=d4).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages