Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8406)

Unified Diff: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc

Issue 2898173007: Disable flaky test EnsureCWSReportAbusePageIsActiveTabAfterUninstall. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
index eaaa0d13bd303817588b91cedf3663513487f361..f9c4bef8d3b31b1b4fe18db3640d7173b57d289b 100644
--- a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
+++ b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
@@ -135,7 +135,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionUninstallDialogViewBrowserTest,
// Test that when the user clicks Uninstall on the ExtensionUninstallDialog, the
// extension's uninstall url (when it is specified) should open and be the
// active tab.
-// DISABLED: Flaky on Win 10 x64
+// TODO(catmullings): Disabled due to flake on Win 10 x64.
+// https://crbug.com/725197
IN_PROC_BROWSER_TEST_F(
ExtensionUninstallDialogViewBrowserTest,
DISABLED_EnsureExtensionUninstallURLIsActiveTabAfterUninstall) {
@@ -189,17 +190,11 @@ IN_PROC_BROWSER_TEST_F(
// on the ExtensionUninstallDialog, the extension's uninstall url (when it is
// specified) and the CWS Report Abuse survey are opened in the browser, also
// testing that the CWS survey is the active tab.
-#if defined(OS_WIN)
-// Flaky on windows: http://crbug.com/725197
-#define MAYBE_EnsureCWSReportAbusePageIsActiveTabAfterUninstall \
- DISABLED_EnsureCWSReportAbusePageIsActiveTabAfterUninstall
-#else
-#define MAYBE_EnsureCWSReportAbusePageIsActiveTabAfterUninstall \
- EnsureCWSReportAbusePageIsActiveTabAfterUninstall
-#endif
+// TODO(catmullings): Disabled due to flake on Windows and Linux.
+// http://crbug.com/725197
IN_PROC_BROWSER_TEST_F(
ExtensionUninstallDialogViewBrowserTest,
- MAYBE_EnsureCWSReportAbusePageIsActiveTabAfterUninstall) {
+ DISABLED_EnsureCWSReportAbusePageIsActiveTabAfterUninstall) {
scoped_refptr<extensions::Extension> extension(BuildTestExtension());
ExtensionService* extension_service =
extensions::ExtensionSystem::Get(browser()->profile())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698