Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2898173006: restricts when context could be retrieved. (Closed)
Patch Set: address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 050e4a0327200ee54f81593db486b9769f482d0e..6c5c0155d0fd0c730769529ff2efccf9161e721c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3347,10 +3347,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="AuthPolicy.TimeToRunKlist" units="ms">
<owner>ljusten@chromium.org</owner>
<summary>
- Time in milliseconds to call 'klist' (print Kerberos ticket-granting-
- ticket information). The command reveals a TGT's lifetime, which is used to
- determine TGT status in GetUserStatus() called periodically by Chrome.
- The value is recorded no matter if the operation was successful or not.
+ Time in milliseconds to call 'klist' (print Kerberos ticket-granting- ticket
+ information). The command reveals a TGT's lifetime, which is used to
+ determine TGT status in GetUserStatus() called periodically by Chrome. The
+ value is recorded no matter if the operation was successful or not.
</summary>
</histogram>
@@ -79824,6 +79824,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="VoiceInteraction.IllegalContextRequest">
Ilya Sherman 2017/05/25 22:21:16 nit: Please add enum="BooleanHit".
Muyuan 2017/05/25 22:32:58 Done.
+ <owner>muyuanli@chromium.org</owner>
+ <summary>
+ Counts the number of requests to retrieve voice interaction context when no
+ user interaction is initiated.
+ </summary>
+</histogram>
+
+<histogram name="VoiceInteraction.RequestArrivalSinceUserInteraction"
Ilya Sherman 2017/05/25 22:21:16 Optional nit: I'd name this "UserInteractionToRequ
Muyuan 2017/05/25 22:32:58 Done.
+ units="ms">
+ <owner>muyuanli@chromium.org</owner>
+ <summary>
+ Records the time between user interaction and the actual request arrival.
+ </summary>
+</histogram>
+
<histogram name="VRDisplayPresentResult" enum="PresentationResult">
<owner>billorr@chromium.org</owner>
<summary>

Powered by Google App Engine
This is Rietveld 408576698