 Chromium Code Reviews
 Chromium Code Reviews Issue 2898163002:
  Make non-Module generators only context allocate parameters.  (Closed)
    
  
    Issue 2898163002:
  Make non-Module generators only context allocate parameters.  (Closed) 
  | Index: src/debug/debug-scopes.h | 
| diff --git a/src/debug/debug-scopes.h b/src/debug/debug-scopes.h | 
| index d187f3e7bd90fc2ce17ee44a4bad8f4d9a2015e0..7ffd9d1cf947630acc29b929335481ae42d4515d 100644 | 
| --- a/src/debug/debug-scopes.h | 
| +++ b/src/debug/debug-scopes.h | 
| @@ -93,7 +93,8 @@ class ScopeIterator { | 
| }; | 
| Isolate* isolate_; | 
| - FrameInspector* const frame_inspector_; | 
| + FrameInspector* const frame_inspector_ = nullptr; | 
| + Handle<JSGeneratorObject> generator_; | 
| Handle<Context> context_; | 
| List<ExtendedScopeInfo> nested_scope_chain_; | 
| Handle<StringSet> non_locals_; | 
| @@ -103,9 +104,14 @@ class ScopeIterator { | 
| return frame_inspector_->GetArgumentsFrame(); | 
| } | 
| - inline Handle<JSFunction> GetFunction() { | 
| - return frame_inspector_->GetFunction(); | 
| - } | 
| + Handle<Context> GetFrameContext(); | 
| 
neis
2017/05/24 10:39:37
Why not just GetContext? (like GetFunction etc)
 | 
| + Handle<JSFunction> GetFunction(); | 
| + int GetSourcePosition(); | 
| + | 
| + void MaterializeStackLocals(Handle<JSObject> local_scope, | 
| + Handle<ScopeInfo> scope_info); | 
| + | 
| + void TryParseAndRetrieveScopes(ScopeIterator::Option option); | 
| void RetrieveScopeChain(DeclarationScope* scope); | 
| @@ -133,7 +139,7 @@ class ScopeIterator { | 
| Handle<Object> new_value); | 
| // Helper functions. | 
| - bool SetParameterValue(Handle<ScopeInfo> scope_info, JavaScriptFrame* frame, | 
| + bool SetParameterValue(Handle<ScopeInfo> scope_info, | 
| Handle<String> parameter_name, | 
| Handle<Object> new_value); | 
| bool SetStackVariableValue(Handle<ScopeInfo> scope_info, |