Cleanup how a best fit function is found when setting a breakpoint.

Cleanup how a best fit function is found when setting a breakpoint.

1. Look for functions/closures only in the script where the breakpoint
is being set.
2. If an inner most closure is found, return that as the best fit.
3. When going over a class' functions, return immediately when a fit is
found as going over the other class functions will not yield a narrower
fit.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/1eaa3dd84baf04db4ab7c437c734dceaa27785a3

[sivachandra, 2017-05-25 00:48:21]

sivachandra@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-05-25 01:26:25]

lgtm

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2662: GrowableObjectArray& closures =
GrowableObjectArray::Handle(zone);
Maybe this can be

const GrowableObjectArray& closures = GrowableObjectArray::Handle(
  zone, isolate_->object_store()->closure_functions());

as we are not modifying closures in this function.

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2667: closures =
isolate_->object_store()->closure_functions();
this line will not be needed if initialized in above fashion.

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2721: return best_fit.raw();
can this be return Function::null();

[sivachandra, 2017-05-25 04:48:18]

PTAL

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2662: GrowableObjectArray& closures =
GrowableObjectArray::Handle(zone);
On 2017/05/25 01:26:25, siva wrote:
> Maybe this can be
> 
> const GrowableObjectArray& closures = GrowableObjectArray::Handle(
>   zone, isolate_->object_store()->closure_functions());
> 
> as we are not modifying closures in this function.

Done.

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2667: closures =
isolate_->object_store()->closure_functions();
On 2017/05/25 01:26:25, siva wrote:
> this line will not be needed if initialized in above fashion.

Done.

https://codereview.chromium.org/2898153006/diff/1/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:2721: return best_fit.raw();
On 2017/05/25 01:26:25, siva wrote:
> can this be return Function::null();

Done.

[sivachandra, 2017-05-25 19:57:45]

Description was changed from

==========
Cleanup how a best fit function is found when setting a breakpoint.

1. Look for functions/closures only in the script where the breakpoint
is being set.
2. If an inner most closure is found, return that as the best fit.
3. When going over a class' functions, return immediately when a fit is
found as going over the other class functions will not yield a narrower
fit.

BUG=
==========

to

==========
Cleanup how a best fit function is found when setting a breakpoint.

1. Look for functions/closures only in the script where the breakpoint
is being set.
2. If an inner most closure is found, return that as the best fit.
3. When going over a class' functions, return immediately when a fit is
found as going over the other class functions will not yield a narrower
fit.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1eaa3dd84baf04db4ab7c437c734dceaa27785a3
==========

[sivachandra, 2017-05-25 19:57:46]

Committed patchset #2 (id:20001) manually as
1eaa3dd84baf04db4ab7c437c734dceaa27785a3 (presubmit successful).