Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: components/ntp_snippets/features.cc

Issue 2898153004: [NTP::Push] Add feature (Closed)
Patch Set: Remvoing unnecessary "NTP" from the feature name. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/features.h" 5 #include "components/ntp_snippets/features.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/time/clock.h" 9 #include "base/time/clock.h"
10 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h " 10 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h "
11 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h" 11 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h"
12 #include "components/variations/variations_associated_data.h" 12 #include "components/variations/variations_associated_data.h"
13 13
14 namespace ntp_snippets { 14 namespace ntp_snippets {
15 15
16 // Keep sorted, and keep nullptr at the end. 16 // Keep sorted, and keep nullptr at the end.
17 const base::Feature*(kAllFeatures[]) = {&kArticleSuggestionsFeature, 17 const base::Feature*(kAllFeatures[]) = {&kArticleSuggestionsFeature,
18 &kBookmarkSuggestionsFeature, 18 &kBookmarkSuggestionsFeature,
19 &kCategoryOrder, 19 &kCategoryOrder,
20 &kCategoryRanker, 20 &kCategoryRanker,
21 &kForeignSessionsSuggestionsFeature, 21 &kForeignSessionsSuggestionsFeature,
22 &kPushUpdatesFeature,
22 &kIncreasedVisibility, 23 &kIncreasedVisibility,
23 &kNotificationsFeature, 24 &kNotificationsFeature,
24 &kPhysicalWebPageSuggestionsFeature, 25 &kPhysicalWebPageSuggestionsFeature,
25 &kPreferAmpUrlsFeature, 26 &kPreferAmpUrlsFeature,
26 &kPublisherFaviconsFromNewServerFeature, 27 &kPublisherFaviconsFromNewServerFeature,
27 &kRecentOfflineTabSuggestionsFeature, 28 &kRecentOfflineTabSuggestionsFeature,
28 nullptr}; 29 nullptr};
29 30
30 const base::Feature kArticleSuggestionsFeature{ 31 const base::Feature kArticleSuggestionsFeature{
31 "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 32 "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
32 33
33 const base::Feature kBookmarkSuggestionsFeature{ 34 const base::Feature kBookmarkSuggestionsFeature{
34 "NTPBookmarkSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 35 "NTPBookmarkSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
35 36
36 const base::Feature kRecentOfflineTabSuggestionsFeature{ 37 const base::Feature kRecentOfflineTabSuggestionsFeature{
37 "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 38 "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
38 39
39 const base::Feature kIncreasedVisibility{"NTPSnippetsIncreasedVisibility", 40 const base::Feature kIncreasedVisibility{"NTPSnippetsIncreasedVisibility",
40 base::FEATURE_ENABLED_BY_DEFAULT}; 41 base::FEATURE_ENABLED_BY_DEFAULT};
41 42
42 const base::Feature kPhysicalWebPageSuggestionsFeature{ 43 const base::Feature kPhysicalWebPageSuggestionsFeature{
43 "NTPPhysicalWebPageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 44 "NTPPhysicalWebPageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
44 45
45 const base::Feature kForeignSessionsSuggestionsFeature{ 46 const base::Feature kForeignSessionsSuggestionsFeature{
46 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 47 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
47 48
49 const base::Feature kPushUpdatesFeature{"NTPPushUpdates",
50 base::FEATURE_DISABLED_BY_DEFAULT};
51
48 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls", 52 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls",
49 base::FEATURE_ENABLED_BY_DEFAULT}; 53 base::FEATURE_ENABLED_BY_DEFAULT};
50 54
51 const base::Feature kCategoryRanker{"ContentSuggestionsCategoryRanker", 55 const base::Feature kCategoryRanker{"ContentSuggestionsCategoryRanker",
52 base::FEATURE_ENABLED_BY_DEFAULT}; 56 base::FEATURE_ENABLED_BY_DEFAULT};
53 57
54 const base::Feature kPublisherFaviconsFromNewServerFeature{ 58 const base::Feature kPublisherFaviconsFromNewServerFeature{
55 "ContentSuggestionsFaviconsFromNewServer", 59 "ContentSuggestionsFaviconsFromNewServer",
56 base::FEATURE_DISABLED_BY_DEFAULT}; 60 base::FEATURE_DISABLED_BY_DEFAULT};
57 61
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 const char kNotificationsTextValuePublisher[] = "publisher"; 139 const char kNotificationsTextValuePublisher[] = "publisher";
136 const char kNotificationsTextValueSnippet[] = "snippet"; 140 const char kNotificationsTextValueSnippet[] = "snippet";
137 const char kNotificationsTextValueAndMore[] = "and_more"; 141 const char kNotificationsTextValueAndMore[] = "and_more";
138 const char kNotificationsKeepWhenFrontmostParam[] = 142 const char kNotificationsKeepWhenFrontmostParam[] =
139 "keep_notification_when_frontmost"; 143 "keep_notification_when_frontmost";
140 const char kNotificationsOpenToNTPParam[] = "open_to_ntp"; 144 const char kNotificationsOpenToNTPParam[] = "open_to_ntp";
141 const char kNotificationsDailyLimit[] = "daily_limit"; 145 const char kNotificationsDailyLimit[] = "daily_limit";
142 const char kNotificationsIgnoredLimitParam[] = "ignored_limit"; 146 const char kNotificationsIgnoredLimitParam[] = "ignored_limit";
143 147
144 } // namespace ntp_snippets 148 } // namespace ntp_snippets
OLDNEW
« chrome/browser/flag_descriptions.cc ('K') | « components/ntp_snippets/features.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698