[NTP::Push] Add feature

chrome/browser/flag_descriptions.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/flag_descriptions.h"
 
 namespace flag_descriptions {
 
 //  Material Design version of chrome://bookmarks
 
@@ skipping 2425 matching lines @@
     "If enabled, the list of content suggestions on the New Tab page (see "
     "#enable-ntp-snippets) will contain recent foreign tabs.";
 
 const char kEnableNtpSuggestionsNotificationsName[] =
     "Notify about new content suggestions available at the New Tab page";
 
 const char kEnableNtpSuggestionsNotificationsDescription[] =
     "If enabled, notifications will inform about new content suggestions on "
     "the New Tab page (see #enable-ntp-snippets).";
 
+const char kEnableNtpPushUpdatesName[] =
+    "Receive GCM push updates for timely content at the New Tab Page";

[sfiera, 2017/05/24 14:11:46]

It's not really tied to the New Tab Page. You could just say:
"Receive timely content suggestions via GCM push"

(applies to all places NTP appears in this CL)

[mamir, 2017/05/24 15:07:27]

Done.

+
+const char kEnableNtpPushUpdatesDescription[] =
+    "If enabled, the client will listen for push messages sent from the "
+    "server about timely content such as breaking news.";

[sfiera, 2017/05/24 14:11:46]

Describing this flag in terms of "client" and "server" makes sense to the
implementer but not to others. Better to describe the observable behavior and
not the implementation.
"If enabled, Chrome will register with Google services to receive content
suggestions via push (in addition to normal background polling). Push will be
used for timely content, such as breaking news."

[mamir, 2017/05/24 15:07:27]

Done.

+
 const char kNtpCondensedLayoutName[] = "Condensed NTP layout";
 
 const char kNtpCondensedLayoutDescription[] =
     "Show a condensed layout on the New Tab Page.";
 
 const char kNtpCondensedTileLayoutName[] = "Condensed NTP tile layout";
 
 const char kNtpCondensedTileLayoutDescription[] =
     "Show a condensed tile layout on the New Tab Page.";
 
@@ skipping 724 matching lines @@
 
 const char kDisableNewVirtualKeyboardBehaviorName[] =
     "New window behavior for the accessibility keyboard";
 const char kDisableNewVirtualKeyboardBehaviorDescription[] =
     "Disable new window behavior for the accessibility keyboard "
     "in non-sticky mode (do not change work area in non-sticky mode).";
 
 #endif  // defined(OS_CHROMEOS)
 
 }  // namespace flag_descriptions