Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp

Issue 2898133002: CSS: Use count unitless 0 supplied as <angle> (Closed)
Patch Set: Optional Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
index 284158d3d8244314361cc653967efe6515207ebf..7b09f7e262ea7399695e5598ef577ecce2d2cac4 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp
@@ -11,6 +11,8 @@
namespace blink {
+using namespace CSSPropertyParserHelpers;
+
const CSSValue* CSSPropertyAPIRotate::parseSingleValue(
CSSParserTokenRange& range,
const CSSParserContext& context,
@@ -19,13 +21,12 @@ const CSSValue* CSSPropertyAPIRotate::parseSingleValue(
CSSValueID id = range.Peek().Id();
if (id == CSSValueNone)
- return CSSPropertyParserHelpers::ConsumeIdent(range);
+ return ConsumeIdent(range);
CSSValueList* list = CSSValueList::CreateSpaceSeparated();
for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation
- CSSValue* dimension =
- CSSPropertyParserHelpers::ConsumeNumber(range, kValueRangeAll);
+ CSSValue* dimension = ConsumeNumber(range, kValueRangeAll);
if (!dimension) {
if (i == 0)
break;
@@ -34,7 +35,8 @@ const CSSValue* CSSPropertyAPIRotate::parseSingleValue(
list->Append(*dimension);
}
- CSSValue* rotation = CSSPropertyParserHelpers::ConsumeAngle(range);
+ CSSValue* rotation = ConsumeAngle(range, context, UnitlessQuirk::kForbid,
+ WTF::Optional<UseCounter::Feature>());
if (!rotation)
return nullptr;
list->Append(*rotation);

Powered by Google App Engine
This is Rietveld 408576698