third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp - Issue 2898133002: CSS: Use count unitless 0 supplied as <angle>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp

Issue 2898133002: CSS: Use count unitless 0 supplied as <angle> (Closed)

Patch Set: test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp

diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp

index ea70595f1c722c30284df849612415f9cd5fa501..835eb27833fff6a1a8d26e46344fb7ecf02cd99a 100644

--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp

+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageOrientation.cpp

@@ -19,7 +19,8 @@ const CSSValue* CSSPropertyAPIImageOrientation::parseSingleValue(

if (range.Peek().Id() == CSSValueFromImage)

return CSSPropertyParserHelpers::ConsumeIdent(range);

if (range.Peek().GetType() != kNumberToken) {

- CSSPrimitiveValue* angle = CSSPropertyParserHelpers::ConsumeAngle(range);

+ CSSPrimitiveValue* angle = CSSPropertyParserHelpers::ConsumeAngle(

+ range, context, WTF::Optional<UseCounter::Feature>());

if (angle && angle->GetDoubleValue() == 0)

return angle;

}