Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAPIRotate.cpp

Issue 2898133002: CSS: Use count unitless 0 supplied as <angle> (Closed)
Patch Set: Optional Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/css/properties/CSSPropertyAPIRotate.h" 5 #include "core/css/properties/CSSPropertyAPIRotate.h"
6 6
7 #include "core/CSSValueKeywords.h" 7 #include "core/CSSValueKeywords.h"
8 #include "core/css/CSSValueList.h" 8 #include "core/css/CSSValueList.h"
9 #include "core/css/parser/CSSPropertyParserHelpers.h" 9 #include "core/css/parser/CSSPropertyParserHelpers.h"
10 #include "platform/RuntimeEnabledFeatures.h" 10 #include "platform/RuntimeEnabledFeatures.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 using namespace CSSPropertyParserHelpers;
15
14 const CSSValue* CSSPropertyAPIRotate::parseSingleValue( 16 const CSSValue* CSSPropertyAPIRotate::parseSingleValue(
15 CSSParserTokenRange& range, 17 CSSParserTokenRange& range,
16 const CSSParserContext& context, 18 const CSSParserContext& context,
17 CSSPropertyID) { 19 CSSPropertyID) {
18 DCHECK(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled()); 20 DCHECK(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
19 21
20 CSSValueID id = range.Peek().Id(); 22 CSSValueID id = range.Peek().Id();
21 if (id == CSSValueNone) 23 if (id == CSSValueNone)
22 return CSSPropertyParserHelpers::ConsumeIdent(range); 24 return ConsumeIdent(range);
23 25
24 CSSValueList* list = CSSValueList::CreateSpaceSeparated(); 26 CSSValueList* list = CSSValueList::CreateSpaceSeparated();
25 27
26 for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation 28 for (unsigned i = 0; i < 3; i++) { // 3 dimensions of rotation
27 CSSValue* dimension = 29 CSSValue* dimension = ConsumeNumber(range, kValueRangeAll);
28 CSSPropertyParserHelpers::ConsumeNumber(range, kValueRangeAll);
29 if (!dimension) { 30 if (!dimension) {
30 if (i == 0) 31 if (i == 0)
31 break; 32 break;
32 return nullptr; 33 return nullptr;
33 } 34 }
34 list->Append(*dimension); 35 list->Append(*dimension);
35 } 36 }
36 37
37 CSSValue* rotation = CSSPropertyParserHelpers::ConsumeAngle(range); 38 CSSValue* rotation = ConsumeAngle(range, context, UnitlessQuirk::kForbid,
39 WTF::Optional<UseCounter::Feature>());
38 if (!rotation) 40 if (!rotation)
39 return nullptr; 41 return nullptr;
40 list->Append(*rotation); 42 list->Append(*rotation);
41 43
42 return list; 44 return list;
43 } 45 }
44 46
45 } // namespace blink 47 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698