Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2898083002: dart2js kernel: generate `other==null` header for operator== methods (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js kernel: generate `other==null` header for operator== methods BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/7fb377d3af95f62a1a191b1f49ac9e7857f1a563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +29 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 7 months ago (2017-05-22 23:12:15 UTC) #4
Emily Fortuna
lgtm
3 years, 7 months ago (2017-05-22 23:21:27 UTC) #5
sra1
3 years, 7 months ago (2017-05-23 00:06:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
7fb377d3af95f62a1a191b1f49ac9e7857f1a563 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698