third_party/WebKit/Source/core/dom/DOMTokenList.cpp - Issue 2898063003: DOMTokenList.contains() should not throw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMTokenList.cpp

Issue 2898063003: DOMTokenList.contains() should not throw. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMTokenList.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMTokenList.cpp b/third_party/WebKit/Source/core/dom/DOMTokenList.cpp

index e7d658e2a95146c7b8e8692f64b1320db8fa6b13..48c9c6207c0d63ce01a47928610d46ac11d43a62 100644

--- a/third_party/WebKit/Source/core/dom/DOMTokenList.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMTokenList.cpp

@@ -67,10 +67,8 @@ bool DOMTokenList::ValidateTokenValue(const AtomicString&,

return false;

}

-bool DOMTokenList::contains(const AtomicString& token,

- ExceptionState& exception_state) const {

- if (!ValidateToken(token, exception_state))

- return false;

+bool DOMTokenList::contains(const AtomicString& token) const {

+ // https://dom.spec.whatwg.org/#dom-domtokenlist-contains

kochi 2017/05/23 04:15:01 nit: comment above function? (see line 63 for exam

tkent 2017/05/23 05:19:38 Done.

return ContainsInternal(token);

}