Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: components/component_updater/default_component_installer.h

Issue 2898063002: Hold cros_component_installers in browser_process. (Closed)
Patch Set: trim code Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/component_updater/default_component_installer.h
diff --git a/components/component_updater/default_component_installer.h b/components/component_updater/default_component_installer.h
index 61e6c56e7670df661e4a40603667a39e2411edb1..4feb6ec8d9f2105fcf8db0cd5975e11575b32500 100644
--- a/components/component_updater/default_component_installer.h
+++ b/components/component_updater/default_component_installer.h
@@ -124,9 +124,11 @@ class DefaultComponentInstaller : public update_client::CrxInstaller {
// Only user-level component installations can be uninstalled.
bool Uninstall() override;
- private:
+ protected:
~DefaultComponentInstaller() override;
+ std::unique_ptr<base::DictionaryValue> current_manifest_;
sky 2017/05/24 16:47:20 Style guide says no protected members.
xiaochu 2017/05/24 19:56:54 Done.
+ private:
// If there is a installation of the component set up alongside Chrome's
// files (as opposed to in the user data directory), sets current_* to the
// values associated with that installation and returns true; otherwise,
@@ -145,7 +147,6 @@ class DefaultComponentInstaller : public update_client::CrxInstaller {
base::FilePath current_install_dir_;
base::Version current_version_;
std::string current_fingerprint_;
- std::unique_ptr<base::DictionaryValue> current_manifest_;
std::unique_ptr<ComponentInstallerTraits> installer_traits_;
scoped_refptr<base::SequencedTaskRunner> task_runner_;
« chrome/browser/component_updater/cros_component_installer_unittest.cc ('K') | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698