Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: chrome/browser/browser_process.h

Issue 2898063002: Hold cros_component_installers in browser_process. (Closed)
Patch Set: update commit message. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This interface is for managing the global services of the application. Each 5 // This interface is for managing the global services of the application. Each
6 // service is lazily created when requested the first time. The service getters 6 // service is lazily created when requested the first time. The service getters
7 // will return NULL if the service is not available, so callers must check for 7 // will return NULL if the service is not available, so callers must check for
8 // this condition. 8 // this condition.
9 9
10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_ 10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 namespace subresource_filter { 48 namespace subresource_filter {
49 class ContentRulesetService; 49 class ContentRulesetService;
50 } 50 }
51 51
52 namespace variations { 52 namespace variations {
53 class VariationsService; 53 class VariationsService;
54 } 54 }
55 55
56 namespace component_updater { 56 namespace component_updater {
57 class ComponentInstallerTraits;
57 class ComponentUpdateService; 58 class ComponentUpdateService;
59 class DefaultComponentInstaller;
58 class PnaclComponentInstaller; 60 class PnaclComponentInstaller;
59 class SupervisedUserWhitelistInstaller; 61 class SupervisedUserWhitelistInstaller;
60 } 62 }
61 63
62 namespace extensions { 64 namespace extensions {
63 class EventRouterForwarder; 65 class EventRouterForwarder;
64 } 66 }
65 67
66 namespace gcm { 68 namespace gcm {
67 class GCMDriver; 69 class GCMDriver;
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 257
256 virtual net_log::ChromeNetLog* net_log() = 0; 258 virtual net_log::ChromeNetLog* net_log() = 0;
257 259
258 virtual component_updater::ComponentUpdateService* component_updater() = 0; 260 virtual component_updater::ComponentUpdateService* component_updater() = 0;
259 261
260 virtual CRLSetFetcher* crl_set_fetcher() = 0; 262 virtual CRLSetFetcher* crl_set_fetcher() = 0;
261 263
262 virtual component_updater::PnaclComponentInstaller* 264 virtual component_updater::PnaclComponentInstaller*
263 pnacl_component_installer() = 0; 265 pnacl_component_installer() = 0;
264 266
267 #if defined(OS_CHROMEOS)
268 virtual component_updater::DefaultComponentInstaller*
waffles 2017/05/23 20:40:14 I think you actually want to return the Traits obj
xiaochu 2017/05/23 21:31:59 Done. Thanks for pointing this out. I just realiz
269 cros_component_installer(
270 const std::string& name,
271 std::unique_ptr<component_updater::ComponentInstallerTraits>
272 installer_traits) = 0;
273 #endif
274
265 virtual component_updater::SupervisedUserWhitelistInstaller* 275 virtual component_updater::SupervisedUserWhitelistInstaller*
266 supervised_user_whitelist_installer() = 0; 276 supervised_user_whitelist_installer() = 0;
267 277
268 virtual MediaFileSystemRegistry* media_file_system_registry() = 0; 278 virtual MediaFileSystemRegistry* media_file_system_registry() = 0;
269 279
270 virtual bool created_local_state() const = 0; 280 virtual bool created_local_state() const = 0;
271 281
272 #if BUILDFLAG(ENABLE_WEBRTC) 282 #if BUILDFLAG(ENABLE_WEBRTC)
273 virtual WebRtcLogUploader* webrtc_log_uploader() = 0; 283 virtual WebRtcLogUploader* webrtc_log_uploader() = 0;
274 #endif 284 #endif
(...skipping 14 matching lines...) Expand all
289 // Returns the Physical Web data source. 299 // Returns the Physical Web data source.
290 virtual physical_web::PhysicalWebDataSource* GetPhysicalWebDataSource() = 0; 300 virtual physical_web::PhysicalWebDataSource* GetPhysicalWebDataSource() = 0;
291 301
292 private: 302 private:
293 DISALLOW_COPY_AND_ASSIGN(BrowserProcess); 303 DISALLOW_COPY_AND_ASSIGN(BrowserProcess);
294 }; 304 };
295 305
296 extern BrowserProcess* g_browser_process; 306 extern BrowserProcess* g_browser_process;
297 307
298 #endif // CHROME_BROWSER_BROWSER_PROCESS_H_ 308 #endif // CHROME_BROWSER_BROWSER_PROCESS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698