Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/browser_process.h

Issue 2898063002: Hold cros_component_installers in browser_process. (Closed)
Patch Set: update commit message Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This interface is for managing the global services of the application. Each 5 // This interface is for managing the global services of the application. Each
6 // service is lazily created when requested the first time. The service getters 6 // service is lazily created when requested the first time. The service getters
7 // will return NULL if the service is not available, so callers must check for 7 // will return NULL if the service is not available, so callers must check for
8 // this condition. 8 // this condition.
9 9
10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_ 10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_H_
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 namespace subresource_filter { 48 namespace subresource_filter {
49 class ContentRulesetService; 49 class ContentRulesetService;
50 } 50 }
51 51
52 namespace variations { 52 namespace variations {
53 class VariationsService; 53 class VariationsService;
54 } 54 }
55 55
56 namespace component_updater { 56 namespace component_updater {
57 class ComponentInstallerTraits;
57 class ComponentUpdateService; 58 class ComponentUpdateService;
59 class DefaultComponentInstaller;
58 class PnaclComponentInstaller; 60 class PnaclComponentInstaller;
59 class SupervisedUserWhitelistInstaller; 61 class SupervisedUserWhitelistInstaller;
60 } 62 }
61 63
62 namespace extensions { 64 namespace extensions {
63 class EventRouterForwarder; 65 class EventRouterForwarder;
64 } 66 }
65 67
66 namespace gcm { 68 namespace gcm {
67 class GCMDriver; 69 class GCMDriver;
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 284
283 // Returns the default web client state of Chrome (i.e., was it the user's 285 // Returns the default web client state of Chrome (i.e., was it the user's
284 // default browser) at the time a previous check was made sometime between 286 // default browser) at the time a previous check was made sometime between
285 // process startup and now. 287 // process startup and now.
286 virtual shell_integration::DefaultWebClientState 288 virtual shell_integration::DefaultWebClientState
287 CachedDefaultWebClientState() = 0; 289 CachedDefaultWebClientState() = 0;
288 290
289 // Returns the Physical Web data source. 291 // Returns the Physical Web data source.
290 virtual physical_web::PhysicalWebDataSource* GetPhysicalWebDataSource() = 0; 292 virtual physical_web::PhysicalWebDataSource* GetPhysicalWebDataSource() = 0;
291 293
294 #if defined(OS_CHROMEOS)
sky 2017/05/23 20:22:23 Can this be moved to browser_process_platform_part
xiaochu 2017/05/23 21:31:59 Done.
295 virtual component_updater::DefaultComponentInstaller*
296 cros_component_installer(
sky 2017/05/23 20:22:23 Please name this GetCrosComponentInstaller().
xiaochu 2017/05/23 21:31:59 Done.
297 const std::string& name,
298 std::unique_ptr<component_updater::ComponentInstallerTraits>
299 installer_traits) = 0;
300 #endif
301
292 private: 302 private:
293 DISALLOW_COPY_AND_ASSIGN(BrowserProcess); 303 DISALLOW_COPY_AND_ASSIGN(BrowserProcess);
294 }; 304 };
295 305
296 extern BrowserProcess* g_browser_process; 306 extern BrowserProcess* g_browser_process;
297 307
298 #endif // CHROME_BROWSER_BROWSER_PROCESS_H_ 308 #endif // CHROME_BROWSER_BROWSER_PROCESS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698