Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2897943004: Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40… (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 3286 matching lines...) Expand 10 before | Expand all | Expand 10 after
3297 ForAllNonThrottledFrameViews([](FrameView& frame_view) { 3297 ForAllNonThrottledFrameViews([](FrameView& frame_view) {
3298 frame_view.Lifecycle().AdvanceTo(DocumentLifecycle::kInPaint); 3298 frame_view.Lifecycle().AdvanceTo(DocumentLifecycle::kInPaint);
3299 }); 3299 });
3300 3300
3301 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 3301 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
3302 if (GetLayoutView()->Layer()->NeedsRepaint()) { 3302 if (GetLayoutView()->Layer()->NeedsRepaint()) {
3303 GraphicsContext graphics_context(*paint_controller_); 3303 GraphicsContext graphics_context(*paint_controller_);
3304 if (RuntimeEnabledFeatures::printBrowserEnabled()) 3304 if (RuntimeEnabledFeatures::printBrowserEnabled())
3305 graphics_context.SetPrinting(true); 3305 graphics_context.SetPrinting(true);
3306 Paint(graphics_context, CullRect(LayoutRect::InfiniteIntRect())); 3306 Paint(graphics_context, CullRect(LayoutRect::InfiniteIntRect()));
3307 paint_controller_->CommitNewDisplayItems(); 3307 paint_controller_->CommitNewDisplayItems(LayoutSize());
3308 } 3308 }
3309 } else { 3309 } else {
3310 // A null graphics layer can occur for painting of SVG images that are not 3310 // A null graphics layer can occur for painting of SVG images that are not
3311 // parented into the main frame tree, or when the FrameView is the main 3311 // parented into the main frame tree, or when the FrameView is the main
3312 // frame view of a page overlay. The page overlay is in the layer tree of 3312 // frame view of a page overlay. The page overlay is in the layer tree of
3313 // the host page and will be painted during painting of the host page. 3313 // the host page and will be painted during painting of the host page.
3314 if (GraphicsLayer* root_graphics_layer = 3314 if (GraphicsLayer* root_graphics_layer =
3315 view.Compositor()->RootGraphicsLayer()) { 3315 view.Compositor()->RootGraphicsLayer()) {
3316 PaintGraphicsLayerRecursively(root_graphics_layer); 3316 PaintGraphicsLayerRecursively(root_graphics_layer);
3317 } 3317 }
(...skipping 2117 matching lines...) Expand 10 before | Expand all | Expand 10 after
5435 void FrameView::SetAnimationHost( 5435 void FrameView::SetAnimationHost(
5436 std::unique_ptr<CompositorAnimationHost> host) { 5436 std::unique_ptr<CompositorAnimationHost> host) {
5437 animation_host_ = std::move(host); 5437 animation_host_ = std::move(host);
5438 } 5438 }
5439 5439
5440 LayoutUnit FrameView::CaretWidth() const { 5440 LayoutUnit FrameView::CaretWidth() const {
5441 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1)); 5441 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
5442 } 5442 }
5443 5443
5444 } // namespace blink 5444 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698