Rename sync and async file system access methods in blink. [blink] (1/4)

public/web/WebPermissionClient.h

Index: public/web/WebPermissionClient.h
diff --git a/public/web/WebPermissionClient.h b/public/web/WebPermissionClient.h
index 474d4f840ddaa6e25394fab263448e9c94b9e5ff..5612a9de82734e3bdbe3ae16078866f8d0bf78f6 100644
--- a/public/web/WebPermissionClient.h
+++ b/public/web/WebPermissionClient.h
@@ -47,7 +47,10 @@ public:
     // Controls whether access to File System is allowed for this frame.
     virtual bool allowFileSystem() { return true; }
 
-    virtual void requestFileSystemAccess(const WebPermissionCallbacks& callbacks) { }
+    // Controls whether access to File System is allowed for this frame.
+    virtual bool requestFileSystemAccessSync() { return true; }

[kinuko, 2014/05/16 10:18:26]

Do we need this?

[Xi Han, 2014/05/16 13:05:51]

We rename allowFileSystem to requestFileSystemAccessSync. This is function is
just a copy of allowFileSystem.

On 2014/05/16 10:18:26, kinuko wrote:

+
+    virtual void requestFileSystemAccessAsync(const WebPermissionCallbacks& callbacks) { }

[kinuko, 2014/05/19 08:38:04]

This can be also done in the other CL, but I suspect you'll need default
implementation for this to allow the request by default, or will need to
implement this method in WebPermissions object so that layout tests can run.
(You can look for the callsites of setPermissionClient() and see what we do
differently for full chrome / aw case and content_shell case)

 
     // Controls whether images are allowed for this frame.
     virtual bool allowImage(bool enabledPerSettings, const WebURL& imageURL) { return enabledPerSettings; }