Rename sync and async file system access methods in blink. [blink] (1/4)

Source/web/WorkerPermissionClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 
 class WorkerPermissionClient FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerPermissionClient>, public WillBeHeapSupplement<WebCore::WorkerClients> {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerPermissionClient);
 public:
     static PassOwnPtrWillBeRawPtr<WorkerPermissionClient> create(PassOwnPtr<WebWorkerPermissionClientProxy>);
 
     virtual ~WorkerPermissionClient();
 
     bool allowDatabase(const WebString& name, const WebString& displayName, unsigned long estimatedSize);
     bool allowFileSystem();
-    void requestFileSystemAccess(const WebPermissionCallbacks&);
+    bool requestFileSystemAccessSync();
+    void requestFileSystemAccessAsync(const WebPermissionCallbacks&);

[kinuko, 2014/05/16 10:18:26]

Hmm, do we need this?

[Xi Han, 2014/05/16 13:05:51]

In this CL, I only do renaming, since this function is still used in
LocalFileSystemClient.cpp now. It will be removed in the following CL (issue
277353002).

On 2014/05/16 10:18:26, kinuko wrote:

[kinuko, 2014/05/19 08:38:04]

It's fine since now it's landed, but I don't think we call this method in
LocalFileSystemClient.cpp any more, even without waiting for issue 277353002.
(Line 78 in the file, where we call
WorkerPermissionClient::from(*toWorkerGlobalScope(context))->requestFileSystemAccessSync()
seems to be the only code LocalFileSystemClient calls into this)

     bool allowIndexedDB(const WebString& name);
 
     static const char* supplementName();
     static WorkerPermissionClient* from(WebCore::ExecutionContext&);
 
     virtual void trace(WebCore::Visitor* visitor) OVERRIDE { WillBeHeapSupplement<WebCore::WorkerClients>::trace(visitor); }
 
 private:
     explicit WorkerPermissionClient(PassOwnPtr<WebWorkerPermissionClientProxy>);
 
     OwnPtr<WebWorkerPermissionClientProxy> m_proxy;
 };
 
 void providePermissionClientToWorker(WebCore::WorkerClients*, PassOwnPtr<WebWorkerPermissionClientProxy>);
 
 } // namespace blink
 
 #endif // WorkerPermissionClient_h