third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl - Issue 2897833004: Refactored out need to pass property ID in background list parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 2897833004: Refactored out need to pass property ID in background list parsing. (Closed)

Patch Set: changed enum to enum class and addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

index 8cedb1cd881f869cb7f41e3fa066c531283cc0ba..1d7d53fd38add2c2eae6497469ed71d5063ff2be 100644

--- a/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

@@ -114,6 +114,7 @@ namespace blink {

{{declare_value_function(property_id)}} {

CSS{{animation}}Data& data = state.Style()->Access{{animation}}s();

data.{{vector}}.clear();

+ DCHECK(value.IsBaseValueList());

for (auto& listValue : ToCSSValueList(value))

data.{{vector}}.push_back(CSSToStyleMap::MapAnimation{{attribute}}(*listValue));

}