Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2897683002: Move code for instantiating Invocation to Target. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org, aam, scheglov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update expectation file. #

Patch Set 3 : Resolve issues after merging. #

Patch Set 4 : Rename vmTarget to targetInfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -82 lines) Patch
M pkg/compiler/lib/src/kernel/fasta_support.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 4 chunks +12 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_target.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 5 chunks +10 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/shaker_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/super_rasta_copy.dart.direct.expect View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/lib/target/flutter.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/kernel/lib/target/targets.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 2 chunks +65 lines, -1 line 0 comments Download
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 1 2 3 5 chunks +12 lines, -54 lines 0 comments Download
M runtime/lib/invocation_mirror_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
This adds option --target to Fasta. This should help with supporting flutter, but by itself ...
3 years, 7 months ago (2017-05-22 07:53:33 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2897683002/diff/1/pkg/kernel/lib/transformations/mixin_full_resolution.dart File pkg/kernel/lib/transformations/mixin_full_resolution.dart (right): https://codereview.chromium.org/2897683002/diff/1/pkg/kernel/lib/transformations/mixin_full_resolution.dart#newcode25 pkg/kernel/lib/transformations/mixin_full_resolution.dart:25: final Target vmTarget; Rename [vmTarget] to [target]? (I ...
3 years, 7 months ago (2017-05-22 12:33:12 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2897683002/diff/1/pkg/kernel/lib/transformations/mixin_full_resolution.dart File pkg/kernel/lib/transformations/mixin_full_resolution.dart (right): https://codereview.chromium.org/2897683002/diff/1/pkg/kernel/lib/transformations/mixin_full_resolution.dart#newcode25 pkg/kernel/lib/transformations/mixin_full_resolution.dart:25: final Target vmTarget; On 2017/05/22 12:33:12, ...
3 years, 7 months ago (2017-05-22 13:30:59 UTC) #4
ahe
3 years, 7 months ago (2017-05-22 13:59:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
4fddc2e4d53fba609a87f0388c5c8dfc1b08d2c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698